From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [linux-sunxi] [PATCH v12 2/2] media: V3s: Add support for Allwinner CSI. Date: Tue, 20 Nov 2018 14:18:16 +0100 Message-ID: <20181120131816.sqwiiics7sannl7f@flea> References: <1540887490-28316-1-git-send-email-yong.deng@magewell.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yxjswbi473wgfxs7" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jagan Teki Cc: Yong Deng , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , Greg Kroah-Hartman , davem@davemloft.net, akpm@linux-foundation.org, Arnd Bergmann , Hans Verkuil , laurent.pinchart@ideasonboard.com, geert@linux-m68k.org, Neil Armstrong , Philipp Zabel , jacopo+renesas@jmondi.org, tglx@linutronix.de, todor.tomov@linaro.org, linux-media , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi@goog List-Id: devicetree@vger.kernel.org --yxjswbi473wgfxs7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 20, 2018 at 06:27:48PM +0530, Jagan Teki wrote: > On Mon, Nov 19, 2018 at 5:38 PM Jagan Teki w= rote: > > > > On Tue, Oct 30, 2018 at 1:49 PM Yong Deng wrot= e: > > > > > > Allwinner V3s SoC features a CSI module with parallel interface. > > > > > > This patch implement a v4l2 framework driver for it. > > > > > > Reviewed-by: Hans Verkuil > > > Reviewed-by: Maxime Ripard > > > Tested-by: Maxime Ripard > > > Signed-off-by: Yong Deng > > > --- > > > MAINTAINERS | 8 + > > > drivers/media/platform/Kconfig | 1 + > > > drivers/media/platform/Makefile | 2 + > > > drivers/media/platform/sunxi/sun6i-csi/Kconfig | 9 + > > > drivers/media/platform/sunxi/sun6i-csi/Makefile | 3 + > > > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 915 +++++++++++= ++++++++++ > > > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 135 +++ > > > .../media/platform/sunxi/sun6i-csi/sun6i_csi_reg.h | 196 +++++ > > > .../media/platform/sunxi/sun6i-csi/sun6i_video.c | 678 +++++++++++= ++++ > > > .../media/platform/sunxi/sun6i-csi/sun6i_video.h | 38 + > > > 10 files changed, 1985 insertions(+) > > > create mode 100644 drivers/media/platform/sunxi/sun6i-csi/Kconfig > > > create mode 100644 drivers/media/platform/sunxi/sun6i-csi/Makefile > > > create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > > > create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_= reg.h > > > create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_vide= o.c > > > create mode 100644 drivers/media/platform/sunxi/sun6i-csi/sun6i_vide= o.h > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 23021e0df5d7..42d73b35ed3e 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -3900,6 +3900,14 @@ M: Jaya Kumar > > > S: Maintained > > > F: sound/pci/cs5535audio/ > > > > > > +CSI DRIVERS FOR ALLWINNER V3s > > > +M: Yong Deng > > > +L: linux-media@vger.kernel.org > > > +T: git git://linuxtv.org/media_tree.git > > > +S: Maintained > > > +F: drivers/media/platform/sunxi/sun6i-csi/ > > > +F: Documentation/devicetree/bindings/media/sun6i-csi.txt > > > + > > > CW1200 WLAN driver > > > M: Solomon Peachy > > > S: Maintained > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/= Kconfig > > > index 0edacfb01f3a..be6626ed0ec8 100644 > > > --- a/drivers/media/platform/Kconfig > > > +++ b/drivers/media/platform/Kconfig > > > @@ -138,6 +138,7 @@ source "drivers/media/platform/am437x/Kconfig" > > > source "drivers/media/platform/xilinx/Kconfig" > > > source "drivers/media/platform/rcar-vin/Kconfig" > > > source "drivers/media/platform/atmel/Kconfig" > > > +source "drivers/media/platform/sunxi/sun6i-csi/Kconfig" > > > > [snip] > > > > > + > > > + return 0; > > > +} > > > + > > > +static int sun6i_subdev_notify_complete(struct v4l2_async_notifier *= notifier) > > > +{ > > > + struct sun6i_csi *csi =3D container_of(notifier, struct sun6i= _csi, > > > + notifier); > > > + struct v4l2_device *v4l2_dev =3D &csi->v4l2_dev; > > > + struct v4l2_subdev *sd; > > > + int ret; > > > + > > > + dev_dbg(csi->dev, "notify complete, all subdevs registered\n"= ); > > > + > > > + if (notifier->num_subdevs !=3D 1) > > > > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c: In function > > =E2=80=98sun6i_subdev_notify_complete=E2=80=99: > > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:646:14: error: > > =E2=80=98struct v4l2_async_notifier=E2=80=99 has no member named =E2=80= =98num_subdevs=E2=80=99 >=20 > This build issues on linux-next, let me know you have next version > changes for this, thanks. This driver has been merged now, and you have a fix on the thread starting from the cover letter of that very same version. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --yxjswbi473wgfxs7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCW/QJmAAKCRDj7w1vZxhR xXPxAP0XOPSudKmyDUATuzZ0EwbJ7icI2KvTyGc4AoEF4X+//gD+IkJH37A5tu2v fPAYHkrJ+U51Qfhijjtv5f3LI/M4jgs= =nIVd -----END PGP SIGNATURE----- --yxjswbi473wgfxs7--