From: Chris Coffey <cmc@babblebit.net>
To: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Peter Rosin <peda@axentia.se>, Slawomir Stepien <sst@poczta.fm>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Chris Coffey <cmc@babblebit.net>
Subject: [PATCH v3 0/2] Add support for Microchip MCP41xxx/42xxx potentiometers
Date: Tue, 20 Nov 2018 14:17:11 +0000 [thread overview]
Message-ID: <20181120141713.9963-1-cmc@babblebit.net> (raw)
Hello all,
This patch series adds device-tree documentation and driver support
for the Microchip MCP41xxx/42xxx family of digital potentiometers.
Changes in v3:
- Get device names from mcp41010_cfg struct instead of spi device as
suggested by Jonathan Cameron.
- Refactor code structure in mcp41010_write_raw() as recommended by
Jonathan Cameron.
- Only call spi_get_device_id() when necessary to load config as
suggested by Slawomir Stepien.
- In mcp41010_probe(), return err to make static checkers happy as
recommended by Jonathan Cameron.
- Edit mcp41010_match struct members to fit on one line as suggested
by Slawomir Stepien.
- In device tree binding documentation, add company name to example
as pointed out by Slawomir Stepien.
- In device tree binding documentation, remove mcp41010 prefix from
example as suggested by Jonathan Cameron.
Changes in v2:
- Move device tree binding documentation to separate commit as
pointed out by Himanshu Jha.
- Remove explicit '= 0' initialization in mcp41010_type enum as
recommended by Himanshu Jha.
- Change MCP41010_WRITE from (0x01 << 4) to BIT(4) as recommended by
Himanshu Jha.
- Use of_device_get_match_data() to load configuration as
recommended by Peter Rosin.
- Rename MCP41010_WIPER_ENABLE to MCP41010_WIPER_CHANNEL as
suggested by Peter Rosin.
- Remove CONFIG_OF build protections as recommended by Jonathan
Cameron.
- Remove of_match_ptr wrapper from mcp41010_driver struct as
recommended by Jonathan Cameron.
- Remove blank line in mcp41010.c intro as recommended by Jonathan
Cameron.
Chris Coffey (2):
dt-bindings: iio: potentiometer: Add Microchip MCP41xxx/42xxx
iio: potentiometer: Add driver for Microchip MCP41xxx/42xxx
.../bindings/iio/potentiometer/mcp41010.txt | 29 +++
drivers/iio/potentiometer/Kconfig | 12 ++
drivers/iio/potentiometer/Makefile | 1 +
drivers/iio/potentiometer/mcp41010.c | 204 +++++++++++++++++++++
4 files changed, 246 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/mcp41010.txt
create mode 100644 drivers/iio/potentiometer/mcp41010.c
--
2.11.0
next reply other threads:[~2018-11-20 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 14:17 Chris Coffey [this message]
2018-11-20 14:17 ` [PATCH v3 1/2] dt-bindings: iio: potentiometer: Add Microchip MCP41xxx/42xxx Chris Coffey
2018-11-25 12:28 ` Jonathan Cameron
2018-11-20 14:17 ` [PATCH v3 2/2] iio: potentiometer: Add driver for " Chris Coffey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120141713.9963-1-cmc@babblebit.net \
--to=cmc@babblebit.net \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).