Re: [PATCH v2 9/9] dt-bindings: iio: imu: st_lsm6dsx: add support to i2c pullup resistors

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 17 Nov 2018 18:24:03 +0100
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:

> > On Sat, 17 Nov 2018 09:37:54 -0600
> > Rob Herring <robh@kernel.org> wrote:
> >  
> 
> [...]
> 
> > > >  Optional properties:
> > > >  - st,drdy-int-pin: the pin on the package that will be used to signal
> > > >    "data ready" (valid values: 1 or 2).
> > > > +- st,pullups : enable/disable internal i2c controller pullup resistors.  
> > >
> > > bias-pull-up is the standard property for this.  
> >
> > The problem here is 'of what?'.  Perhaps it wasn't clear in the current
> > binding either, but we are talking the pull ups on the auxilliary i2c bus
> > (which doesn't really have a direct representation in DT at all).
> > If we just go with bias-pull-up my instinct would be that it was applying
> > to the drdy pin for example.
> >
> > Lorenzo, could you send a follow up patch fixing this once we
> > have it pinned down?
> >  
> 
> Sure, it sounds good. IIUC we should use 'bias-pull-up' here, without
> vendor info, right?
Yes, though my concern about it being on it's own without any reference
points.  Makes it unobvious what we are applying the pull up on.

Jonathan

> 
> Regards,
> Lorenzo
> 
> > We have plenty of time to get it in before the end of the cycle, so I would
> > rather do that than revert this series over it.  Conversely I don't
> > want a binding we are still discussing getting into a release.  I should have
> > given Rob time to get to this.  Lots of precedence doesn't mean there isn't
> > a better way!  Sorry All.
> >
> > Thanks,
> >
> > Jonathan
> >  
> > >  
> > > >  - drive-open-drain: the interrupt/data ready line will be configured
> > > >    as open drain, which is useful if several sensors share the same
> > > >    interrupt line. This is a boolean property.
> > > > --
> > > > 2.19.1
> > > >  
> >