Re: [RFC PATCH v3 09/17] pinctrl: sunxi: add support for suniv F1C100s (newer F-series SoCs)

Maxime Ripard
2018-11-22T08:45:26Z

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Hi,

On Wed, Nov 21, 2018 at 09:30:42PM +0300, Mesih Kilinc wrote:
> +static const struct sunxi_pinctrl_desc suniv_f1c100s_pinctrl_data = {
> + .pins = suniv_f1c100s_pins,
> + .npins = ARRAY_SIZE(suniv_f1c100s_pins),
> + .irq_banks = 3,
> + .disable_strict_mode = true,
> +};

One thing I forgot to check before giving my Acked-by, you shouldn't
disable the strict mode here, this is only meant as a legacy option,
new drivers need to enforce it.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering