From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v9 1/8] ASoC: dt-bindings: sun50i-codec-analog: Add headphone amp regulator supply Date: Thu, 22 Nov 2018 16:32:41 +0100 Message-ID: <20181122153241.lzrwhkewg5q4hy2c@flea> References: <20181122102325.29495-1-wens@csie.org> <20181122102325.29495-2-wens@csie.org> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="clfxfbg7mahnnpva" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20181122102325.29495-2-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Vasily Khoruzhick List-Id: devicetree@vger.kernel.org --clfxfbg7mahnnpva Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Thu, Nov 22, 2018 at 06:23:18PM +0800, Chen-Yu Tsai wrote: > On the Allwinner A64 SoC, the audio codec has a built-in headphone > amplifier. This amplifier has a power supply separate from the rest of > the analog audio circuitry. > > Add a regulator supply property to handle this. > > Signed-off-by: Chen-Yu Tsai > --- > Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt b/Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt > index 4f8ad0e04d20..056a098495cc 100644 > --- a/Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt > +++ b/Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt > @@ -4,9 +4,11 @@ Required properties: > - compatible: must be one of the following compatibles: > - "allwinner,sun50i-a64-codec-analog" > - reg: must contain the registers location and length > +- cpvdd-supply: Regulator supply for the headphone amplifier I guess we should make this optional, since even if it's missing, it's going to create a dummy regulator. and that allows to have backward compatibility. For the rest of the series, Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --clfxfbg7mahnnpva--