From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, olof@lixom.net, arnd@arndb.de,
robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net,
marc.zyngier@arm.com, daniel.lezcano@linaro.org,
gregkh@linuxfoundation.org, jslaby@suse.com, afaerber@suse.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org, amit.kucheria@linaro.org,
linus.walleij@linaro.org, zhao_steven@263.net,
overseas.sales@unisoc.com,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v2 15/15] MAINTAINERS: Add entry for RDA Micro SoC architecture
Date: Sat, 24 Nov 2018 16:30:06 +0800 [thread overview]
Message-ID: <201811241627.2eQKZPBL%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181121033652.12247-16-manivannan.sadhasivam@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3785 bytes --]
Hi Manivannan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v4.20-rc3 next-20181123]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/Add-initial-RDA8810PL-SoC-and-Orange-Pi-boards-support/20181123-125507
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/rda-uart.c:619:28: warning: context imbalance in 'rda_uart_port_write' - unexpected unlock
vim +/rda_uart_port_write +619 drivers/tty/serial/rda-uart.c
efb19753 Manivannan Sadhasivam 2018-11-21 588
efb19753 Manivannan Sadhasivam 2018-11-21 589 static void rda_uart_port_write(struct uart_port *port, const char *s,
efb19753 Manivannan Sadhasivam 2018-11-21 590 u_int count)
efb19753 Manivannan Sadhasivam 2018-11-21 591 {
efb19753 Manivannan Sadhasivam 2018-11-21 592 u32 old_irq_mask;
efb19753 Manivannan Sadhasivam 2018-11-21 593 unsigned long flags;
efb19753 Manivannan Sadhasivam 2018-11-21 594 int locked;
efb19753 Manivannan Sadhasivam 2018-11-21 595
efb19753 Manivannan Sadhasivam 2018-11-21 596 local_irq_save(flags);
efb19753 Manivannan Sadhasivam 2018-11-21 597
efb19753 Manivannan Sadhasivam 2018-11-21 598 if (port->sysrq) {
efb19753 Manivannan Sadhasivam 2018-11-21 599 locked = 0;
efb19753 Manivannan Sadhasivam 2018-11-21 600 } else if (oops_in_progress) {
efb19753 Manivannan Sadhasivam 2018-11-21 601 locked = spin_trylock(&port->lock);
efb19753 Manivannan Sadhasivam 2018-11-21 602 } else {
efb19753 Manivannan Sadhasivam 2018-11-21 603 spin_lock(&port->lock);
efb19753 Manivannan Sadhasivam 2018-11-21 604 locked = 1;
efb19753 Manivannan Sadhasivam 2018-11-21 605 }
efb19753 Manivannan Sadhasivam 2018-11-21 606
efb19753 Manivannan Sadhasivam 2018-11-21 607 old_irq_mask = rda_uart_read(port, RDA_UART_IRQ_MASK);
efb19753 Manivannan Sadhasivam 2018-11-21 608 rda_uart_write(port, 0, RDA_UART_IRQ_MASK);
efb19753 Manivannan Sadhasivam 2018-11-21 609
efb19753 Manivannan Sadhasivam 2018-11-21 610 uart_console_write(port, s, count, rda_console_putchar);
efb19753 Manivannan Sadhasivam 2018-11-21 611
efb19753 Manivannan Sadhasivam 2018-11-21 612 /* wait until all contents have been sent out */
efb19753 Manivannan Sadhasivam 2018-11-21 613 while (!(rda_uart_read(port, RDA_UART_STATUS) & RDA_UART_TX_FIFO_MASK))
efb19753 Manivannan Sadhasivam 2018-11-21 614 cpu_relax();
efb19753 Manivannan Sadhasivam 2018-11-21 615
efb19753 Manivannan Sadhasivam 2018-11-21 616 rda_uart_write(port, old_irq_mask, RDA_UART_IRQ_MASK);
efb19753 Manivannan Sadhasivam 2018-11-21 617
efb19753 Manivannan Sadhasivam 2018-11-21 618 if (locked)
efb19753 Manivannan Sadhasivam 2018-11-21 @619 spin_unlock(&port->lock);
efb19753 Manivannan Sadhasivam 2018-11-21 620
efb19753 Manivannan Sadhasivam 2018-11-21 621 local_irq_restore(flags);
efb19753 Manivannan Sadhasivam 2018-11-21 622 }
efb19753 Manivannan Sadhasivam 2018-11-21 623
:::::: The code at line 619 was first introduced by commit
:::::: efb197538a7e148635e096850a818e3b29b1c4b2 tty: serial: Add RDA8810PL UART driver
:::::: TO: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66615 bytes --]
prev parent reply other threads:[~2018-11-24 8:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 3:36 [PATCH v2 00/15] Add initial RDA8810PL SoC and Orange Pi boards support Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 01/15] dt-bindings: Add RDA Micro vendor prefix Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 02/15] dt-bindings: arm: Document RDA8810PL and reference boards Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 03/15] ARM: Prepare RDA8810PL SoC Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 04/15] dt-bindings: interrupt-controller: Document RDA8810PL intc Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 05/15] arm: dts: Add devicetree for RDA8810PL SoC Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board Manivannan Sadhasivam
2018-11-21 8:55 ` Arnd Bergmann
2018-12-03 15:53 ` Rob Herring
2018-12-03 17:11 ` Olof Johansson
2018-12-03 17:21 ` Rob Herring
2018-12-03 17:53 ` Olof Johansson
2018-11-21 3:36 ` [PATCH v2 07/15] arm: dts: Add devicetree for OrangePi i96 board Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 08/15] irqchip: Add RDA8810PL interrupt driver Manivannan Sadhasivam
2018-11-21 8:41 ` Marc Zyngier
2018-11-21 17:41 ` Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 09/15] dt-bindings: timer: Document RDA8810PL SoC timer Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 10/15] arm: dts: rda8810pl: Add timer support Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 11/15] clocksource: Add clock driver for RDA8810PL SoC Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 12/15] dt-bindings: serial: Document RDA Micro UART Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 13/15] arm: dts: rda8810pl: Add interrupt support for UART Manivannan Sadhasivam
2018-11-21 3:36 ` [PATCH v2 14/15] tty: serial: Add RDA8810PL UART driver Manivannan Sadhasivam
2018-11-22 10:09 ` Greg KH
2018-11-21 3:36 ` [PATCH v2 15/15] MAINTAINERS: Add entry for RDA Micro SoC architecture Manivannan Sadhasivam
2018-11-24 8:30 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201811241627.2eQKZPBL%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jslaby@suse.com \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marc.zyngier@arm.com \
--cc=olof@lixom.net \
--cc=overseas.sales@unisoc.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhao_steven@263.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).