From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] of/property: Add of_fwnode_name()
Date: Mon, 26 Nov 2018 15:05:32 +0200 [thread overview]
Message-ID: <20181126130532.GH10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181126114752.69597-4-heikki.krogerus@linux.intel.com>
On Mon, Nov 26, 2018 at 02:47:52PM +0300, Heikki Krogerus wrote:
> This implements get_name fwnode op for DT.
> +static int of_fwnode_get_name(const struct fwnode_handle *fwnode, char *buf,
> + size_t len)
> +{
> + snprintf(buf, len, "%pOFn", to_of_node(fwnode));
Same concerns.
> + return 0;
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-26 13:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 11:47 [PATCH v3 0/3] device property: Add fwnode_get_name() helper Heikki Krogerus
2018-11-26 11:47 ` [PATCH v3 1/3] device property: Introduce fwnode_get_name() Heikki Krogerus
2018-11-26 12:56 ` Andy Shevchenko
2018-11-26 11:47 ` [PATCH v3 2/3] ACPI: property: Add acpi_fwnode_name() Heikki Krogerus
2018-11-26 13:04 ` Andy Shevchenko
2018-11-26 11:47 ` [PATCH v3 3/3] of/property: Add of_fwnode_name() Heikki Krogerus
2018-11-26 13:05 ` Andy Shevchenko [this message]
2018-11-26 13:40 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126130532.GH10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).