From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state Date: Mon, 26 Nov 2018 13:23:16 +0100 Message-ID: <20181126132316.541a4131@ipc1.ka-ro> References: <20181114215120.vddykljqyavm64wj@pengutronix.de> <20181115152545.GA8611@ulmo> <20181115203733.qvonika6yhn2bsnb@pengutronix.de> <20181116083430.7f1d8452@ipc1.ka-ro> <20181116082557.l2ljgu3hsu7tvdci@pengutronix.de> <91640f9b-d219-553e-043a-c6151f2f68d7@ysoft.com> <20181122162359.ufngpgxkenlmgqni@pengutronix.de> <20181122190321.ktqegs7kpvhcemvi@pengutronix.de> <9da8c6d9-d97c-200c-d8e4-2eb9f73eedc5@ysoft.com> <20181126115123.GA15164@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20181126115123.GA15164@ulmo> Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: =?UTF-8?B?Vm9rw6HEjQ==?= Michal , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Mark Rutland , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Lukasz Majewski , "linux-kernel@vger.kernel.org" , Rob Herring , "kernel@pengutronix.de" , Fabio Estevam , Linus Walleij , viresh kumar List-Id: devicetree@vger.kernel.org Thierry Reding wrote: > On Fri, Nov 23, 2018 at 03:15:11PM +0000, Vokáč Michal wrote: > > On 22.11.2018 20:03, Uwe Kleine-König wrote: > > > On Thu, Nov 22, 2018 at 04:46:39PM +0000, Vokáč Michal wrote: > > >> On 22.11.2018 17:23, Uwe Kleine-König wrote: > > >>> On Thu, Nov 22, 2018 at 03:42:14PM +0000, Vokáč Michal wrote: > > >>>> On 16.11.2018 09:25, Uwe Kleine-König wrote: > > >>>>> On Fri, Nov 16, 2018 at 08:34:30AM +0100, Lothar Waßmann wrote: > > >>>>>> No. You can disable the output driver via pinctrl, so that only the > > >>>>>> selected pull-up/down is relevant. The pin function and GPIO register > > >>>>>> settings don't matter at all in this case. > > >>>> > > >>>> Lothar, please can you be more specific how would you do that? IFAIK the > > >>>> pull-up/down internal resistors have effect only if the pin is configured > > >>>> as GPIO *input* (on i.MX6 at least). See the TRM, 29.4.2.2 Output driver: > > >>>> > > >>>> "Internal pull-up, pull-down resistors, and pad keeper are disabled in > > >>>> output mode." > > > > > > This would mean you'd have to rely on an external pull up for your use > > > case. I wouldn't be surprised however if DSE=0 wouldn't count as "output > > > mode". Given the reliability of NXP documentation I wouldn't bet neither > > > on one nor the other possibility. > > > > Yeah, the NXP documentation sometimes does not really match reality. > > My use case is based on the fact that I configure the pin as input in > > the driver. Then it works just fine. > > > > >>> So I'd expect this to really work on i.MX6 but not the earlier SoCs > > >>> without a gpio specifier. > > >> > > >> Maybe you would expect it to work but I already tested and measured > > >> that weeks ago ;) It did not work. > > > > > > Which pin/gpio do we talk about? Which i.MX6 variant did you test this > > > on? (Assuming i.MX6D or i.MX6Q and PAD_DISP0_DATA09, did you try setting > > > > > > IOMUXC_SW_MUX_CTL_PAD_DISP0_DATA09 (0x020E0194) = 0x00000005 > > > IOMUXC_SW_PAD_CTL_PAD_DISP0_DATA09 (0x020E04A8) = 0x0000b080 > > > > > > and then play with GPIO 4.30 direction and output value?) > > > > My test setup is as follows: > > - SoC is i.MX6DL or i.MX6S - I have three board variants in total. > > - Pin used for PWM/GPIO is PAD_GPIO9. > > - The pin is not connected to any circuit. Just a test point. > > - pinctrl setup in DT: > > - for "pwm": > > - fsl,pins = > > - IOMUXC_SW_MUX_CTL_PAD_GPIO09 = 0x00000004 > > - IOMUXC_SW_PAD_CTL_PAD_GPIO09 = 0x00000008 > > > > - for "gpio": > > - fsl,pins = > > - IOMUXC_SW_MUX_CTL_PAD_GPIO09 = 0x00000005 > > - IOMUXC_SW_PAD_CTL_PAD_GPIO09 = 0x0000b000 > > Does it help if you additionally set the ODE bit (bit 11) here? > That only helps to NOT actively pulling the pin HIGH, but the opposite is what is needed here. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________