From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
viresh.kumar@linaro.org, Chris Redpath <chris.redpath@linaro.org>,
Quentin Perret <quentin.perret@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Nicolas Dechesne <nicolas.dechesne@linaro.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>, Li Yang <leoyang.li@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT
Date: Mon, 26 Nov 2018 16:06:01 +0100 [thread overview]
Message-ID: <20181126150601.GD4637@kroah.com> (raw)
In-Reply-To: <1543234847-21611-2-git-send-email-daniel.lezcano@linaro.org>
On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote:
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -243,9 +243,20 @@ static int __init register_cpufreq_notifier(void)
> * until we have the necessary code to parse the cpu capacity, so
> * skip registering cpufreq notifier.
> */
> - if (!acpi_disabled || !raw_capacity)
> + if (!acpi_disabled)
> return -EINVAL;
>
> + if (!raw_capacity) {
> +
> + pr_info("cpu_capacity: No capacity defined in DT, set default "
> + "values to %ld\n", SCHED_CAPACITY_SCALE);
Why the extra blank line?
And what is userspace going to do with this noise? Is this an error?
Just normal operation? A device should never be saying anything to the
log for normal boot functionality. When is this called?
And no need for the "cpu_capacity:" right? Shouldn't the pr_info() line
handle the prefix for you?
thanks,
greg k-h
next prev parent reply other threads:[~2018-11-26 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1543234847-21611-1-git-send-email-daniel.lezcano@linaro.org>
2018-11-26 12:20 ` [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT Daniel Lezcano
2018-11-26 12:48 ` Quentin Perret
2018-11-26 12:49 ` Daniel Lezcano
2018-11-26 15:06 ` Greg Kroah-Hartman [this message]
2018-11-26 20:08 ` Daniel Lezcano
2018-11-27 1:42 ` Rob Herring
2018-11-27 3:57 ` Viresh Kumar
2018-11-27 8:31 ` Daniel Lezcano
2018-11-27 9:09 ` Quentin Perret
2018-11-27 10:15 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126150601.GD4637@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amit.kucheria@linaro.org \
--cc=chris.redpath@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.dechesne@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=quentin.perret@linaro.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).