From: Pavel Machek <pavel@ucw.cz>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: johan@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>
Subject: Re: [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna
Date: Tue, 27 Nov 2018 19:03:57 +0100 [thread overview]
Message-ID: <20181127180356.GA32751@localhost> (raw)
In-Reply-To: <20181118215801.12280-5-andreas@kemnade.info>
Hi!
> Devices might have a separate lna between antenna output of the gps
> chip and the antenna which might have a separate supply
Might have.
> @@ -340,6 +349,12 @@ static int sirf_probe(struct serdev_device *serdev)
> goto err_put_device;
> }
>
> + data->lna = devm_regulator_get(dev, "lna");
> + if (IS_ERR(data->lna)) {
> + ret = PTR_ERR(data->lna);
> + goto err_put_device;
> + }
> +
But it is not optional in the code. Probably should be?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2018-11-27 18:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 21:57 [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna Andreas Kemnade
2018-11-18 21:57 ` [PATCH 1/5] gnss: sirf: write data to gnss only when the gnss device is open Andreas Kemnade
2018-12-05 14:47 ` Johan Hovold
2018-12-05 20:14 ` Andreas Kemnade
2018-11-18 21:57 ` [PATCH 2/5] gnss: sirf: power on logic for devices without wakeup signal Andreas Kemnade
2018-11-19 8:37 ` H. Nikolaus Schaller
2018-12-05 15:01 ` Johan Hovold
2018-12-05 22:15 ` Andreas Kemnade
2018-11-18 21:57 ` [PATCH 3/5] dt-bindings: gnss: add w2sg0004 compatible string Andreas Kemnade
2018-12-04 22:57 ` Rob Herring
2018-12-05 15:01 ` Johan Hovold
2018-11-18 21:58 ` [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna Andreas Kemnade
2018-11-19 8:41 ` [Letux-kernel] " H. Nikolaus Schaller
2018-11-27 18:03 ` Pavel Machek [this message]
2018-11-30 6:38 ` Andreas Kemnade
2018-11-30 8:43 ` Pavel Machek
2018-12-05 15:06 ` Johan Hovold
2018-11-18 21:58 ` [PATCH RFC 5/5] dt-bindings: gnss: add lna-supply property Andreas Kemnade
2018-12-04 22:59 ` Rob Herring
2018-12-05 15:09 ` Johan Hovold
2018-12-09 19:11 ` Andreas Kemnade
2018-11-19 8:22 ` [Letux-kernel] [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna H. Nikolaus Schaller
2018-11-19 18:44 ` Andreas Kemnade
2018-11-19 19:05 ` H. Nikolaus Schaller
2018-12-05 15:19 ` [Letux-kernel] " Johan Hovold
2018-12-05 16:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127180356.GA32751@localhost \
--to=pavel@ucw.cz \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).