From: Shawn Guo <shawnguo@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, Anson Huang <anson.huang@nxp.com>,
patchwork-lst@pengutronix.de, NXP Linux Team <linux-imx@nxp.com>,
kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] soc: imx: gpcv2: add support for i.MX8MQ SoC
Date: Wed, 28 Nov 2018 10:57:10 +0800 [thread overview]
Message-ID: <20181128025709.GF20643@dragon> (raw)
In-Reply-To: <20181116154927.16152-3-l.stach@pengutronix.de>
On Fri, Nov 16, 2018 at 04:49:27PM +0100, Lucas Stach wrote:
> The GPCv2 on the Freescale i.MX8MQ SoC works in the same way as the
> GPCv2 on the i.MX7, but only controls more power domains with a
> different mapping.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> .../bindings/power/fsl,imx-gpcv2.txt | 7 +-
The series looks good to me.
@Rob, can you please ACK on the bindings change?
Shawn
> drivers/soc/imx/Kconfig | 6 +-
> drivers/soc/imx/Makefile | 2 +-
> drivers/soc/imx/gpcv2.c | 208 +++++++++++++++++-
> include/dt-bindings/power/imx8mq-power.h | 21 ++
> 5 files changed, 237 insertions(+), 7 deletions(-)
> create mode 100644 include/dt-bindings/power/imx8mq-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> index 9acce75b29ab..7c947a996df1 100644
> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> @@ -6,7 +6,9 @@ Control (PGC) for various power domains.
>
> Required properties:
>
> -- compatible: Should be "fsl,imx7d-gpc"
> +- compatible: Should be one of:
> + - "fsl,imx7d-gpc"
> + - "fsl,imx8mq-gpc"
>
> - reg: should be register base and length as documented in the
> datasheet
> @@ -22,7 +24,8 @@ which, in turn, is expected to contain the following:
> Required properties:
>
> - reg: Power domain index. Valid values are defined in
> - include/dt-bindings/power/imx7-power.h
> + include/dt-bindings/power/imx7-power.h for fsl,imx7d-gpc and
> + include/dt-bindings/power/imx8m-power.h for fsl,imx8mq-gpc
>
> - #power-domain-cells: Should be 0
next prev parent reply other threads:[~2018-11-28 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 15:49 [PATCH 1/3] soc: imx: gpcv2: prefix i.MX7 specific defines Lucas Stach
2018-11-16 15:49 ` [PATCH 2/3] soc: imx: gpcv2: move register access table to domain data Lucas Stach
2018-11-16 15:49 ` [PATCH 3/3] soc: imx: gpcv2: add support for i.MX8MQ SoC Lucas Stach
2018-11-28 2:57 ` Shawn Guo [this message]
2018-12-04 22:00 ` Rob Herring
2018-12-05 0:51 ` [PATCH 1/3] soc: imx: gpcv2: prefix i.MX7 specific defines Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128025709.GF20643@dragon \
--to=shawnguo@kernel.org \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=patchwork-lst@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).