From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Jon Hunter <jonathanh@nvidia.com>, Timo Alho <talho@nvidia.com>,
Pekka Pessi <ppessi@nvidia.com>,
Mika Liljeberg <mliljeberg@nvidia.com>,
linux-tegra@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH v3 02/12] mailbox: Allow multiple controllers per device
Date: Wed, 28 Nov 2018 10:54:11 +0100 [thread overview]
Message-ID: <20181128095421.20573-3-thierry.reding@gmail.com> (raw)
In-Reply-To: <20181128095421.20573-1-thierry.reding@gmail.com>
From: Mikko Perttunen <mperttunen@nvidia.com>
Look through the whole controller list when mapping device tree
phandles to controllers instead of stopping at the first one.
Each controller is intended to only contain one kind of mailbox,
but some devices (like Tegra HSP) implement multiple kinds and use
the same device tree node for all of them. As such, we need to allow
multiple mbox_controllers per device tree node.
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
drivers/mailbox/mailbox.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
index 044e24804767..fbdcc82a61ae 100644
--- a/drivers/mailbox/mailbox.c
+++ b/drivers/mailbox/mailbox.c
@@ -355,7 +355,8 @@ struct mbox_chan *mbox_request_channel(struct mbox_client *cl, int index)
list_for_each_entry(mbox, &mbox_cons, node)
if (mbox->dev->of_node == spec.np) {
chan = mbox->of_xlate(mbox, &spec);
- break;
+ if (!IS_ERR(chan))
+ break;
}
of_node_put(spec.np);
--
2.19.1
next prev parent reply other threads:[~2018-11-28 20:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:54 [PATCH v3 00/12] serial: Add Tegra Combined UART driver Thierry Reding
2018-11-28 9:54 ` [PATCH v3 01/12] mailbox: Support blocking transfers in atomic context Thierry Reding
2018-11-28 9:54 ` Thierry Reding [this message]
2018-11-28 9:54 ` [PATCH v3 03/12] dt-bindings: tegra186-hsp: Add shared mailboxes Thierry Reding
2018-11-28 9:54 ` [PATCH v3 04/12] mailbox: tegra-hsp: Add support for " Thierry Reding
2018-11-28 9:54 ` [PATCH v3 05/12] mailbox: tegra-hsp: Add suspend/resume support Thierry Reding
2018-11-28 9:54 ` [PATCH v3 06/12] mailbox: tegra-hsp: use devm_kstrdup_const() Thierry Reding
2018-11-28 9:54 ` [PATCH v3 07/12] mailbox: tegra-hsp: Use device-managed registration API Thierry Reding
2018-11-28 9:54 ` [PATCH v3 08/12] dt-bindings: serial: Add bindings for nvidia,tegra194-tcu Thierry Reding
2018-11-28 9:54 ` [PATCH v3 09/12] serial: Add Tegra Combined UART driver Thierry Reding
2018-11-28 9:54 ` [PATCH v3 10/12] arm64: tegra: Add nodes for TCU on Tegra194 Thierry Reding
2018-11-28 9:54 ` [PATCH v3 11/12] arm64: tegra: Mark TCU as primary serial port on Tegra194 P2888 Thierry Reding
2018-11-28 9:54 ` [PATCH v3 12/12] arm64: defconfig: Enable Tegra TCU Thierry Reding
2018-12-05 16:15 ` [PATCH v3 00/12] serial: Add Tegra Combined UART driver Thierry Reding
2018-12-22 5:13 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128095421.20573-3-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=jslaby@suse.com \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mliljeberg@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=ppessi@nvidia.com \
--cc=talho@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).