From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support Date: Wed, 28 Nov 2018 10:12:30 +0100 Message-ID: <20181128101230.435bfbeb@ipc1.ka-ro> References: <1543311334-8807-1-git-send-email-Anson.Huang@nxp.com> <1543311334-8807-5-git-send-email-Anson.Huang@nxp.com> <20181128100420.0c9a721a@karo-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Anson Huang Cc: "a.zummo@towertech.it" , "alexandre.belloni@bootlin.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Aisheng DONG , Andy Gross , "arnd@arndb.de" , "horms+renesas@verge.net.au" , "heiko@sntech.de" , "bjorn.andersson@linaro.org" , "enric.balletbo@collabora.com" , "amit.kucheria@linaro.org" , "ezequiel@collabora.com" , "olof@lixom.net" sh List-Id: devicetree@vger.kernel.org Anson Huang wrote: > Hi, Lothar > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Lothar Waßmann [mailto:LW@KARO-electronics.de] > > Sent: 2018年11月28日 17:04 > > To: Anson Huang > > Cc: a.zummo@towertech.it; alexandre.belloni@bootlin.com; > > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com; > > will.deacon@arm.com; Aisheng DONG ; Andy Gross > > ; arnd@arndb.de; horms+renesas@verge.net.au; > > heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com; > > amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net; > > shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > dl-linux-imx > > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > > RTC support > > > > Hi, > > > > On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > > > Add i.MX8QXP system controller RTC support. > > > > > > Signed-off-by: Anson Huang > > > --- > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > index 9155d45..ef57db6 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > @@ -433,4 +433,8 @@ > > > #size-cells = <1>; > > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > > }; > > > + > > > + rtc: rtc { > > > + compatible = "nxp,imx8qxp-sc-rtc"; > > > + }; > > > }; > > IMO this should be disabled by default. > > This module is NOT depending on any board design, should it be enabled by default in soc dtsi? > Like wdog etc.. > What about existing users (if there are any), which would have a new device appearing when updating the DTB? Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________