From: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Alexandre Belloni
<alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 12/15] ARM: dts: sunxi: h3/h5: Fix up RTC device node and clock references
Date: Wed, 28 Nov 2018 11:27:45 +0100 [thread overview]
Message-ID: <20181128102745.v2dvq24jjf4vxrbd@flea> (raw)
In-Reply-To: <20181128093013.24442-14-wens-jdAy2FN1RRM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Wed, Nov 28, 2018 at 05:30:10PM +0800, Chen-Yu Tsai wrote:
> The RTC module on the H3 was claimed to be the same as on the A31, when
> in fact it is not. The A31 does not have an RTC external clock output,
> and its internal RC oscillator's average clock rate is not in the same
> range. The H5's RTC has some extra crypto-related registers compared to
> the H3. Their exact functions are not clear. Also the RTC-VIO regulator
> has different settings.
>
> This patch fixes the compatible string and clock properties to conform
> to the updated bindings. The device node for the internal oscillator is
> removed, as it is internalized into the RTC device. Clock references to
> the IOSC and LOSC are also fixed.
>
> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Acked-by: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
> squash! ARM: dts: sunxi: h3/h5: Fix up RTC device node and clock references
But you might want to remove that :)
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-28 10:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:29 [PATCH 00/15] rtc: sun6i: clock rework and pre-H6 SoC support Chen-Yu Tsai
2018-11-28 9:29 ` [PATCH 01/15] dt-bindings: rtc: sun6i-rtc: Rewrite clock outputs as a list Chen-Yu Tsai
[not found] ` <20181128093013.24442-2-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:17 ` Maxime Ripard
[not found] ` <20181128093013.24442-1-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 9:29 ` [PATCH 02/15] dt-bindings: rtc: sun6i-rtc: Add compatible strings for pre-H6 variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-3-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:19 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 03/15] dt-bindings: rtc: sun6i-rtc: Deprecate external clock output for A31 Chen-Yu Tsai
[not found] ` <20181128093013.24442-4-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:20 ` Maxime Ripard
2018-11-28 11:15 ` Chen-Yu Tsai
2018-11-28 9:30 ` [PATCH 04/15] dt-bindings: rtc: sun6i-rtc: Export internal RC oscillator Chen-Yu Tsai
2018-11-28 10:32 ` Maxime Ripard
2018-11-28 11:18 ` Chen-Yu Tsai
[not found] ` <CAGb2v67jPi-RFFkVrzHeh2XHeZV7ZN0tPCE=cOTpd6RQayH_Kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-03 9:06 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 05/15] rtc: sun6i: Add default clock name for LOSC Chen-Yu Tsai
[not found] ` <20181128093013.24442-6-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:21 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 06/15] rtc: sun6i: Add support for different variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-7-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:22 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 07/15] rtc: sun6i: Add support for all known pre-H6 variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-8-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:24 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 07/15] rtc: sun6i: Add support for all known variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-9-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 9:44 ` Chen-Yu Tsai
2018-11-28 9:30 ` [PATCH 08/15] rtc: sun6i: Expose internal oscillator through device tree Chen-Yu Tsai
[not found] ` <20181128093013.24442-10-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:33 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 09/15] clk: sunxi-ng: r40: Force LOSC parent to RTC LOSC output Chen-Yu Tsai
[not found] ` <20181128093013.24442-11-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:25 ` Maxime Ripard
2018-11-28 21:29 ` Stephen Boyd
[not found] ` <154344054442.88331.8887745218976145062-n1Xw8LXHxjTHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2018-11-30 3:55 ` Chen-Yu Tsai
2018-11-28 9:30 ` [PATCH 10/15] ARM: dts: sun8i: a23/a33: Fix up RTC device node Chen-Yu Tsai
[not found] ` <20181128093013.24442-12-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:26 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 11/15] ARM: dts: sunxi: h3/h5: Add clock accuracy for external oscillators Chen-Yu Tsai
[not found] ` <20181128093013.24442-13-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:26 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 12/15] ARM: dts: sunxi: h3/h5: Fix up RTC device node and clock references Chen-Yu Tsai
[not found] ` <20181128093013.24442-14-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:27 ` Maxime Ripard [this message]
2018-11-28 9:30 ` [PATCH 13/15] ARM: dts: sun8i: r40: Add clock accuracy for external oscillators Chen-Yu Tsai
2018-11-28 10:28 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 14/15] ARM: dts: sun8i: r40: Add RTC device node Chen-Yu Tsai
[not found] ` <20181128093013.24442-16-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:28 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 15/15] arm64: dts: allwinner: a64: Fix up RTC device node and clock references Chen-Yu Tsai
[not found] ` <20181128093013.24442-17-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:28 ` Maxime Ripard
2018-11-28 18:45 ` [PATCH 00/15] rtc: sun6i: clock rework and pre-H6 SoC support Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128102745.v2dvq24jjf4vxrbd@flea \
--to=maxime.ripard-ldxbnhwyfcjbdgjk7y7tuq@public.gmane.org \
--cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).