From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 04/15] dt-bindings: rtc: sun6i-rtc: Export internal RC oscillator
Date: Wed, 28 Nov 2018 11:32:19 +0100 [thread overview]
Message-ID: <20181128103219.b625lttcgoluhgz5@flea> (raw)
In-Reply-To: <20181128093013.24442-5-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]
On Wed, Nov 28, 2018 at 05:30:01PM +0800, Chen-Yu Tsai wrote:
> Experiments showed that on at least the H3/H5/A64 the RTC's internal
> oscillator also feeds the CPUS mux in the PRCM.
>
> Export this clock through the device tree, instead of having to use
> a dummy fixed-clock device node, for the PRCM to consume. This will
> properly describe the relationship between the clocks.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> Documentation/devicetree/bindings/rtc/sun6i-rtc.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt b/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt
> index 78c4fb472eb7..1bd37faadecb 100644
> --- a/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt
> +++ b/Documentation/devicetree/bindings/rtc/sun6i-rtc.txt
> @@ -24,7 +24,7 @@ Required properties:
>
> Required properties for new device trees
> - clocks : phandle to the 32kHz external oscillator
> -- clock-output-names : names of the two clock outputs. See below.
> +- clock-output-names : names of the three clock outputs. See below.
> - #clock-cells : must be equal to 1.
>
> The RTC provides the following clocks at the given indices:
> @@ -32,6 +32,7 @@ The RTC provides the following clocks at the given indices:
> - 1: LOSC external output, known as X32KFOUT in the datasheet.
> This clock is not available on the A31 and is deprecated for old
> device trees still using the "allwinner,sun6i-a31-rtc" compatible.
> +- 2: InternalOSC, or internal RC oscillator
It seems to be required only for a few RTC though (H3, H5 and R40?)
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-11-28 10:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:29 [PATCH 00/15] rtc: sun6i: clock rework and pre-H6 SoC support Chen-Yu Tsai
2018-11-28 9:29 ` [PATCH 01/15] dt-bindings: rtc: sun6i-rtc: Rewrite clock outputs as a list Chen-Yu Tsai
[not found] ` <20181128093013.24442-2-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:17 ` Maxime Ripard
[not found] ` <20181128093013.24442-1-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 9:29 ` [PATCH 02/15] dt-bindings: rtc: sun6i-rtc: Add compatible strings for pre-H6 variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-3-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:19 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 03/15] dt-bindings: rtc: sun6i-rtc: Deprecate external clock output for A31 Chen-Yu Tsai
[not found] ` <20181128093013.24442-4-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:20 ` Maxime Ripard
2018-11-28 11:15 ` Chen-Yu Tsai
2018-11-28 9:30 ` [PATCH 04/15] dt-bindings: rtc: sun6i-rtc: Export internal RC oscillator Chen-Yu Tsai
2018-11-28 10:32 ` Maxime Ripard [this message]
2018-11-28 11:18 ` Chen-Yu Tsai
[not found] ` <CAGb2v67jPi-RFFkVrzHeh2XHeZV7ZN0tPCE=cOTpd6RQayH_Kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-03 9:06 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 05/15] rtc: sun6i: Add default clock name for LOSC Chen-Yu Tsai
[not found] ` <20181128093013.24442-6-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:21 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 06/15] rtc: sun6i: Add support for different variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-7-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:22 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 07/15] rtc: sun6i: Add support for all known pre-H6 variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-8-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:24 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 07/15] rtc: sun6i: Add support for all known variants Chen-Yu Tsai
[not found] ` <20181128093013.24442-9-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 9:44 ` Chen-Yu Tsai
2018-11-28 9:30 ` [PATCH 08/15] rtc: sun6i: Expose internal oscillator through device tree Chen-Yu Tsai
[not found] ` <20181128093013.24442-10-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:33 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 09/15] clk: sunxi-ng: r40: Force LOSC parent to RTC LOSC output Chen-Yu Tsai
[not found] ` <20181128093013.24442-11-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:25 ` Maxime Ripard
2018-11-28 21:29 ` Stephen Boyd
[not found] ` <154344054442.88331.8887745218976145062-n1Xw8LXHxjTHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2018-11-30 3:55 ` Chen-Yu Tsai
2018-11-28 9:30 ` [PATCH 10/15] ARM: dts: sun8i: a23/a33: Fix up RTC device node Chen-Yu Tsai
[not found] ` <20181128093013.24442-12-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:26 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 11/15] ARM: dts: sunxi: h3/h5: Add clock accuracy for external oscillators Chen-Yu Tsai
[not found] ` <20181128093013.24442-13-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:26 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 12/15] ARM: dts: sunxi: h3/h5: Fix up RTC device node and clock references Chen-Yu Tsai
[not found] ` <20181128093013.24442-14-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:27 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 13/15] ARM: dts: sun8i: r40: Add clock accuracy for external oscillators Chen-Yu Tsai
2018-11-28 10:28 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 14/15] ARM: dts: sun8i: r40: Add RTC device node Chen-Yu Tsai
[not found] ` <20181128093013.24442-16-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:28 ` Maxime Ripard
2018-11-28 9:30 ` [PATCH 15/15] arm64: dts: allwinner: a64: Fix up RTC device node and clock references Chen-Yu Tsai
[not found] ` <20181128093013.24442-17-wens-jdAy2FN1RRM@public.gmane.org>
2018-11-28 10:28 ` Maxime Ripard
2018-11-28 18:45 ` [PATCH 00/15] rtc: sun6i: clock rework and pre-H6 SoC support Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128103219.b625lttcgoluhgz5@flea \
--to=maxime.ripard@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox