[PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node

[PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node

[Tero Kristo]

Hwmod parses the DT hierarchically from root to search for matching
ti,hwmod property. With the introduction of L4 data, we have two nodes
with the ti,hwmod = "gmac" declaration, and the hwmod core only matches
the first one found, which is the target-module one. This node incorrectly
dropped the ti,no-idle flag, which causes number of problems, like ignoring
errata i877, and also causing an intermittent boot failure on certain dra7
boards.

Fix the issue by moving the ti,no-idle flag to the proper node.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
FYI: The problem is seen in linux-next.

 arch/arm/boot/dts/dra7-l4.dtsi | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
index 7e5c0d4f..6c01ada 100644
--- a/arch/arm/boot/dts/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/dra7-l4.dtsi
@@ -3021,6 +3021,14 @@
 			#address-cells = <1>;
 			#size-cells = <1>;
 			ranges = <0x0 0x84000 0x4000>;
+			/*
+			 * Do not allow gating of cpsw clock as workaround
+			 * for errata i877. Keeping internal clock disabled
+			 * causes the device switching characteristics
+			 * to degrade over time and eventually fail to meet
+			 * the data manual delay time/skew specs.
+			 */
+			ti,no-idle;
 
 			mac: ethernet@0 {
 				compatible = "ti,dra7-cpsw","ti,cpsw";
@@ -3040,15 +3048,6 @@
 				#size-cells = <1>;
 
 				/*
-				 * Do not allow gating of cpsw clock as workaround
-				 * for errata i877. Keeping internal clock disabled
-				 * causes the device switching characteristics
-				 * to degrade over time and eventually fail to meet
-				 * the data manual delay time/skew specs.
-				 */
-				ti,no-idle;
-
-				/*
 				 * rx_thresh_pend
 				 * rx_pend
 				 * tx_pend
-- 
1.9.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node

[Grygorii Strashko]

On 11/28/18 4:45 AM, Tero Kristo wrote:
> Hwmod parses the DT hierarchically from root to search for matching
> ti,hwmod property. With the introduction of L4 data, we have two nodes
> with the ti,hwmod = "gmac" declaration, and the hwmod core only matches
> the first one found, which is the target-module one. This node incorrectly
> dropped the ti,no-idle flag, which causes number of problems, like ignoring
> errata i877, and also causing an intermittent boot failure on certain dra7
> boards.
> 
> Fix the issue by moving the ti,no-idle flag to the proper node.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> FYI: The problem is seen in linux-next.

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> 

-- 
regards,
-grygorii

Re: [PATCH] ARM: dts: dra7: Move the ti, no-idle quirk on proper gmac node

[Tony Lindgren]

* Grygorii Strashko <grygorii.strashko@ti.com> [181128 23:11]:
> 
> 
> On 11/28/18 4:45 AM, Tero Kristo wrote:
> > Hwmod parses the DT hierarchically from root to search for matching
> > ti,hwmod property. With the introduction of L4 data, we have two nodes
> > with the ti,hwmod = "gmac" declaration, and the hwmod core only matches
> > the first one found, which is the target-module one. This node incorrectly
> > dropped the ti,no-idle flag, which causes number of problems, like ignoring
> > errata i877, and also causing an intermittent boot failure on certain dra7
> > boards.
> > 
> > Fix the issue by moving the ti,no-idle flag to the proper node.
> > 
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> > FYI: The problem is seen in linux-next.
> 
> Thank you.
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> 

Thanks for catching it, applying into omap-for-v4.21/dt-ti-sysc.

Regards,

Tony