devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048"
@ 2018-11-29 19:58 Adrian Bunk
  2018-11-29 19:58 ` [PATCH v4 2/2] eeprom: at24: Add 24c2048 Adrian Bunk
  2018-12-07 13:59 ` [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048" Bartosz Golaszewski
  0 siblings, 2 replies; 5+ messages in thread
From: Adrian Bunk @ 2018-11-29 19:58 UTC (permalink / raw)
  To: Bartosz Golaszewski, linux-i2c, Rob Herring, Mark Rutland,
	devicetree

Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
 Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index aededdbc262b..f9a7c984274c 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -27,6 +27,7 @@ Required properties:
                 "atmel,24c256",
                 "atmel,24c512",
                 "atmel,24c1024",
+                "atmel,24c2048",
 
                 If <manufacturer> is not "atmel", then a fallback must be used
                 with the same <model> and "atmel" as manufacturer.
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v4 2/2] eeprom: at24: Add 24c2048
  2018-11-29 19:58 [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048" Adrian Bunk
@ 2018-11-29 19:58 ` Adrian Bunk
  2018-12-07 13:59 ` [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048" Bartosz Golaszewski
  1 sibling, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2018-11-29 19:58 UTC (permalink / raw)
  To: Bartosz Golaszewski, linux-i2c, Rob Herring, Mark Rutland,
	devicetree

Works with an ST M24M02.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
 drivers/misc/eeprom/Kconfig | 2 +-
 drivers/misc/eeprom/at24.c  | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
index fe7a1d27a017..a846faefa210 100644
--- a/drivers/misc/eeprom/Kconfig
+++ b/drivers/misc/eeprom/Kconfig
@@ -13,7 +13,7 @@ config EEPROM_AT24
 	  ones like at24c64, 24lc02 or fm24c04:
 
 	     24c00, 24c01, 24c02, spd (readonly 24c02), 24c04, 24c08,
-	     24c16, 24c32, 24c64, 24c128, 24c256, 24c512, 24c1024
+	     24c16, 24c32, 24c64, 24c128, 24c256, 24c512, 24c1024, 24c2048
 
 	  Unless you like data loss puzzles, always be sure that any chip
 	  you configure as a 24c32 (32 kbit) or larger is NOT really a
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 636ed7149793..ddfcf4ade7bf 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -156,6 +156,7 @@ AT24_CHIP_DATA(at24_data_24c128, 131072 / 8, AT24_FLAG_ADDR16);
 AT24_CHIP_DATA(at24_data_24c256, 262144 / 8, AT24_FLAG_ADDR16);
 AT24_CHIP_DATA(at24_data_24c512, 524288 / 8, AT24_FLAG_ADDR16);
 AT24_CHIP_DATA(at24_data_24c1024, 1048576 / 8, AT24_FLAG_ADDR16);
+AT24_CHIP_DATA(at24_data_24c2048, 2097152 / 8, AT24_FLAG_ADDR16);
 /* identical to 24c08 ? */
 AT24_CHIP_DATA(at24_data_INT3499, 8192 / 8, 0);
 
@@ -182,6 +183,7 @@ static const struct i2c_device_id at24_ids[] = {
 	{ "24c256",	(kernel_ulong_t)&at24_data_24c256 },
 	{ "24c512",	(kernel_ulong_t)&at24_data_24c512 },
 	{ "24c1024",	(kernel_ulong_t)&at24_data_24c1024 },
+	{ "24c2048",    (kernel_ulong_t)&at24_data_24c2048 },
 	{ "at24",	0 },
 	{ /* END OF LIST */ }
 };
@@ -210,6 +212,7 @@ static const struct of_device_id at24_of_match[] = {
 	{ .compatible = "atmel,24c256",		.data = &at24_data_24c256 },
 	{ .compatible = "atmel,24c512",		.data = &at24_data_24c512 },
 	{ .compatible = "atmel,24c1024",	.data = &at24_data_24c1024 },
+	{ .compatible = "atmel,24c2048",	.data = &at24_data_24c2048 },
 	{ /* END OF LIST */ },
 };
 MODULE_DEVICE_TABLE(of, at24_of_match);
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048"
  2018-11-29 19:58 [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048" Adrian Bunk
  2018-11-29 19:58 ` [PATCH v4 2/2] eeprom: at24: Add 24c2048 Adrian Bunk
@ 2018-12-07 13:59 ` Bartosz Golaszewski
  2018-12-07 14:11   ` Wolfram Sang
  1 sibling, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2018-12-07 13:59 UTC (permalink / raw)
  To: Rob Herring; +Cc: linux-i2c, bunk, Mark Rutland, devicetree

czw., 29 lis 2018 o 20:59 Adrian Bunk <bunk@kernel.org> napisał(a):
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index aededdbc262b..f9a7c984274c 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -27,6 +27,7 @@ Required properties:
>                  "atmel,24c256",
>                  "atmel,24c512",
>                  "atmel,24c1024",
> +                "atmel,24c2048",
>
>                  If <manufacturer> is not "atmel", then a fallback must be used
>                  with the same <model> and "atmel" as manufacturer.
> --
> 2.11.0
>

Hi Rob,

this is a trivial patch - can we have your Ack so that I can send my
PR to Wolfram for 4.21?

Thanks in advance,
Bartosz

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048"
  2018-12-07 13:59 ` [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048" Bartosz Golaszewski
@ 2018-12-07 14:11   ` Wolfram Sang
  2018-12-07 23:16     ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2018-12-07 14:11 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Rob Herring, linux-i2c, bunk, Mark Rutland, devicetree

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]


> this is a trivial patch - can we have your Ack so that I can send my
> PR to Wolfram for 4.21?

I think it is OK for trivial patches to go without Rob's explicit ack.
At least this is how I handle it and I think I agreed long time ago with
him about that...


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048"
  2018-12-07 14:11   ` Wolfram Sang
@ 2018-12-07 23:16     ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-12-07 23:16 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Bartosz Golaszewski, linux-i2c, bunk, Mark Rutland, devicetree

On Fri, Dec 07, 2018 at 03:11:06PM +0100, Wolfram Sang wrote:
> 
> > this is a trivial patch - can we have your Ack so that I can send my
> > PR to Wolfram for 4.21?

Pinging won't help. You can check my queue in patchwork.

> I think it is OK for trivial patches to go without Rob's explicit ack.
> At least this is how I handle it and I think I agreed long time ago with
> him about that...
> 

Indeed. In case you still want it:

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-12-07 23:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-29 19:58 [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048" Adrian Bunk
2018-11-29 19:58 ` [PATCH v4 2/2] eeprom: at24: Add 24c2048 Adrian Bunk
2018-12-07 13:59 ` [PATCH v4 1/2] dt-bindings: eeprom: at24: add "atmel,24c2048" Bartosz Golaszewski
2018-12-07 14:11   ` Wolfram Sang
2018-12-07 23:16     ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).