From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Rob Clark <robdclark@gmail.com>, David Airlie <airlied@linux.ie>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Archit Taneja <architt@codeaurora.org>,
Sean Paul <seanpaul@chromium.org>,
Rajesh Yadav <ryadav@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Jeykumar Sankaran <jsanka@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/7] drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT
Date: Fri, 30 Nov 2018 14:32:38 -0800 [thread overview]
Message-ID: <20181130223238.GD22824@google.com> (raw)
In-Reply-To: <CAD=FV=X5r1CCSeTDXy_cYOBDf4ExNe276pFQSC6T+WWg2=SchA@mail.gmail.com>
On Tue, Nov 27, 2018 at 10:00:50PM -0800, Doug Anderson wrote:
> Hi,
>
> On Mon, Nov 26, 2018 at 3:12 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> > @@ -409,8 +410,9 @@ static void dsi_pll_28nm_destroy(struct msm_dsi_pll *pll)
> > static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm)
> > {
> > char *clk_name, *parent_name, *vco_name;
> > + const char *ref_clk_name = __clk_get_name(pll_28nm->vco_ref_clk);
>
> IMO for the 28nm PHY driver you should probably make things work OK
> even if the "ref" clock wasn't supplied. In the spirit of the stable
> device tree it would be nice (even if nobody actually ships device
> trees separate from kernels). ...and also it makes the whole thing
> easier to land. If you add compatibility here then the code and
> device tree patch can go in separately.
Ok, I'll make it fall back to the 'default' values if the ref clock is
not specified.
next prev parent reply other threads:[~2018-11-30 22:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 23:11 [PATCH v2 0/7] drm/msm/dsi: Get PHY ref clocks from the DT Matthias Kaehlcke
2018-11-26 23:11 ` [PATCH v2 1/7] dt-bindings: msm/dsi: Add ref clock for PHYs Matthias Kaehlcke
2018-11-28 5:41 ` Doug Anderson
[not found] ` <CAD=FV=WvXFpZDJGbdvvY=HL_=tDWyhKpTg7zu8s=gUuJgK1ebg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-30 22:16 ` Matthias Kaehlcke
[not found] ` <20181126231159.122298-1-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-11-26 23:11 ` [PATCH v2 2/7] drm/msm/dsi: 14nm PHY: Get ref clock from the DT Matthias Kaehlcke
2018-11-28 5:56 ` Doug Anderson
2018-11-30 22:18 ` Matthias Kaehlcke
2018-11-26 23:11 ` [PATCH v2 3/7] drm/msm/dsi: 28nm 8960 " Matthias Kaehlcke
[not found] ` <20181126231159.122298-4-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-11-28 6:00 ` Doug Anderson
2018-11-30 22:32 ` Matthias Kaehlcke [this message]
2018-11-26 23:11 ` [PATCH v2 5/7] drm/msm/dsi: 28nm " Matthias Kaehlcke
[not found] ` <20181126231159.122298-6-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-11-28 6:18 ` Doug Anderson
2018-11-26 23:11 ` [PATCH v2 7/7] drm/msm/dsi: 10nm " Matthias Kaehlcke
2018-11-28 6:13 ` Doug Anderson
2018-11-26 23:11 ` [PATCH v2 4/7] arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY Matthias Kaehlcke
[not found] ` <20181126231159.122298-5-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-11-28 6:10 ` Doug Anderson
2018-11-26 23:11 ` [PATCH v2 6/7] arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs Matthias Kaehlcke
2018-11-28 6:12 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130223238.GD22824@google.com \
--to=mka@chromium.org \
--cc=airlied@linux.ie \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jsanka@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryadav@codeaurora.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).