From: Olof Johansson <olof@lixom.net>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
arm@kernel.org, Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: aspeed: add missing memory unit-address
Date: Fri, 30 Nov 2018 15:20:40 -0800 [thread overview]
Message-ID: <20181130232040.z4i4sm5dsycxbmlu@localhost> (raw)
In-Reply-To: <20181130015251.20754-1-robh@kernel.org>
On Thu, Nov 29, 2018 at 07:52:51PM -0600, Rob Herring wrote:
> The base aspeed-g5.dtsi already defines a '/memory@80000000' node, so
> '/memory' in the board files create a duplicate node. We're probably
> getting lucky that the bootloader fixes up the memory node that the
> kernel ends up using. Add the unit-address so it's merged with the base
> node.
>
> Found with DT json-schema checks.
>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-aspeed@lists.ozlabs.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Might be better to just remove the node altogether from the SoC dtsi
> file. It's only saving the device_type definition.
Since I'm sweeping DT pull requests right now, and this is pretty
straightforward, I've applied it to next/dt directly.
-Olof
next prev parent reply other threads:[~2018-11-30 23:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 1:52 [PATCH] ARM: dts: aspeed: add missing memory unit-address Rob Herring
2018-11-30 23:20 ` Olof Johansson [this message]
2018-12-02 22:35 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130232040.z4i4sm5dsycxbmlu@localhost \
--to=olof@lixom.net \
--cc=andrew@aj.id.au \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).