From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 30/34] dt-bindings: arm: Convert Tegra board/soc bindings to json-schema Date: Tue, 4 Dec 2018 09:50:22 +0100 Message-ID: <20181204085022.GB25962@ulmo> References: <20181203213223.16986-1-robh@kernel.org> <20181203213223.16986-31-robh@kernel.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aM3YZ0Iwxop3KEKx" Return-path: Content-Disposition: inline In-Reply-To: <20181203213223.16986-31-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Hudson , Frank Rowand , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Grant Likely , Kumar Gala , arm@kernel.org, Mark Rutland , Jonathan Hunter , linux-tegra@vger.kernel.org List-Id: devicetree@vger.kernel.org --aM3YZ0Iwxop3KEKx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 03, 2018 at 03:32:19PM -0600, Rob Herring wrote: > Convert Tegra SoC bindings to DT schema format using json-schema. >=20 > Cc: Mark Rutland > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: devicetree@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/arm/tegra.txt | 65 ----------- > .../devicetree/bindings/arm/tegra.yaml | 101 ++++++++++++++++++ > 2 files changed, 101 insertions(+), 65 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/tegra.txt > create mode 100644 Documentation/devicetree/bindings/arm/tegra.yaml >=20 > diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Documentat= ion/devicetree/bindings/arm/tegra.txt > deleted file mode 100644 > index c59b15f64346..000000000000 > --- a/Documentation/devicetree/bindings/arm/tegra.txt > +++ /dev/null > @@ -1,65 +0,0 @@ > -NVIDIA Tegra device tree bindings > -------------------------------------------- > - > -SoCs > -------------------------------------------- > - > -Each device tree must specify which Tegra SoC it uses, using one of the > -following compatible values: > - > - nvidia,tegra20 > - nvidia,tegra30 > - nvidia,tegra114 > - nvidia,tegra124 > - nvidia,tegra132 > - nvidia,tegra210 > - nvidia,tegra186 > - nvidia,tegra194 > - > -Boards > -------------------------------------------- > - > -Each device tree must specify which one or more of the following > -board-specific compatible values: > - > - ad,medcom-wide > - ad,plutux > - ad,tamonten > - ad,tec > - compal,paz00 > - compulab,trimslice > - nvidia,beaver > - nvidia,cardhu > - nvidia,cardhu-a02 > - nvidia,cardhu-a04 > - nvidia,dalmore > - nvidia,harmony > - nvidia,jetson-tk1 > - nvidia,norrin > - nvidia,p2371-0000 > - nvidia,p2371-2180 > - nvidia,p2571 > - nvidia,p2771-0000 > - nvidia,p2972-0000 > - nvidia,roth > - nvidia,seaboard > - nvidia,tn7 > - nvidia,ventana > - toradex,apalis_t30 > - toradex,apalis_t30-eval > - toradex,apalis_t30-v1.1 > - toradex,apalis_t30-v1.1-eval > - toradex,apalis-tk1 > - toradex,apalis-tk1-eval > - toradex,apalis-tk1-v1.2 > - toradex,apalis-tk1-v1.2-eval > - toradex,colibri_t20 > - toradex,colibri_t20-eval-v3 > - toradex,colibri_t20-iris > - toradex,colibri_t30 > - toradex,colibri_t30-eval-v3 > - > -Trusted Foundations > -------------------------------------------- > -Tegra supports the Trusted Foundation secure monitor. See the > -"tlm,trusted-foundations" binding's documentation for more details. > diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documenta= tion/devicetree/bindings/arm/tegra.yaml > new file mode 100644 > index 000000000000..66493892ffc1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/tegra.yaml > @@ -0,0 +1,101 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/tegra.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# Could you explain what these are? They give 404, so I assume they are more like placeholders and not actually used? > + > +title: NVIDIA Tegra device tree bindings > + > +maintainers: > + - Marcel Ziswiler > + - Peter De Schrijver Not sure how you got that list, but probably from git history. I think it makes sense to replace Marcel and Peter with Jon and myself. Other than that, looks fine to me. Some of the enumerations below look somewhat hard to parse, but I suspect that it will become second nature in no time. Acked-by: Thierry Reding > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - compal,paz00 > + - compulab,trimslice > + - nvidia,harmony > + - nvidia,seaboard > + - nvidia,ventana > + - const: nvidia,tegra20 > + - items: > + - enum: > + - ad,medcom-wide > + - ad,plutux > + - ad,tec > + - const: ad,tamonten > + - const: nvidia,tegra20 > + - items: > + - enum: > + - toradex,colibri_t20-eval-v3 > + - toradex,colibri_t20-iris > + - const: toradex,colibri_t20 > + - const: nvidia,tegra20 > + - items: > + - enum: > + - nvidia,beaver > + - const: nvidia,tegra30 > + - items: > + - enum: > + - nvidia,cardhu-a02 > + - nvidia,cardhu-a04 > + - const: nvidia,cardhu > + - const: nvidia,tegra30 > + - items: > + - const: toradex,apalis_t30-eval > + - const: toradex,apalis_t30 > + - const: nvidia,tegra30 > + - items: > + - const: toradex,apalis_t30-eval-v1.1 > + - const: toradex,apalis_t30-eval > + - const: toradex,apalis_t30-v1.1 > + - const: toradex,apalis_t30 > + - const: nvidia,tegra30 > + - items: > + - enum: > + - toradex,colibri_t30-eval-v3 > + - const: toradex,colibri_t30 > + - const: nvidia,tegra30 > + - items: > + - enum: > + - nvidia,dalmore > + - nvidia,roth > + - nvidia,tn7 > + - const: nvidia,tegra114 > + - items: > + - enum: > + - nvidia,jetson-tk1 > + - nvidia,venice2 > + - const: nvidia,tegra124 > + - items: > + - const: toradex,apalis-tk1-eval > + - const: toradex,apalis-tk1 > + - const: nvidia,tegra124 > + - items: > + - const: toradex,apalis-tk1-v1.2-eval > + - const: toradex,apalis-tk1-eval > + - const: toradex,apalis-tk1-v1.2 > + - const: toradex,apalis-tk1 > + - const: nvidia,tegra124 > + - items: > + - enum: > + - nvidia,norrin > + - const: nvidia,tegra132 > + - const: nvidia,tegra124 > + - items: > + - enum: > + - nvidia,p2371-0000 > + - nvidia,p2371-2180 > + - nvidia,p2571 > + - const: nvidia,tegra210 > + - items: > + - enum: > + - nvidia,p2771-0000 > + - const: nvidia,tegra186 > + - items: > + - enum: > + - nvidia,p2972-0000 > + - const: nvidia,tegra194 > --=20 > 2.19.1 >=20 --aM3YZ0Iwxop3KEKx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlwGP80ACgkQ3SOs138+ s6F1lBAAqWmjjJqzXAlRqT/zeIxORQ/tP15oBBfsyT07n9XQ3qEnuR4sq0B24TBl l63/fZ+81/lpv8Ile8LcnKIJs0ojIbSqo4RhDks0NkOID8+LhFRBQ6TlMAonqN99 VvtBXYCQTFWs0tk7qyz7/Nj5rsrJgpkKnKmmlRL+g0+tjz4IgrJWFkt4IJcJ9C8h FWXB67whBSkXxeXR2GPY/6tYoAzgJWo2f6YxeRbXKZNaLV+cx3nUSrp60zIvRjgn qdd3Hxj9OkIQ2vybA6+QPEz5AVsR+IhK4rcMj99gYswPykQ1xsc0r+L9iBn/9XwF pwQZI2Bq/axHmqx6w2xW76tE78Dkb8K/t2N1J00ygr+z+Y4DTYtSkwvp1F18gSbK FZQX1ymsc9qbA9MzBJGgLJ63szn5nIOFIb4wuP+fLYjbwj5MFO07oe5ArB0du2H1 Ciy1BLTTu5aqCXgTRnk24vE4pl1KaZNKdBwaNdhdrNQNAHDK30caNlqxrF5i7HGi WFjlJr0M/Hf6duGWU0FBGtNLKaEPtVxHggjMeQV28gLm93Rw0P2yeqOcBquRgCfp mEfmzvKLreReUfkH0Z58U9YESrsnM8FHn7HEJg736hTHjrzTmpSlOpWGy5KahXIz cikPOjKsTP01LJEJ6/2D31XkAOGD55md3v8n38tI2LxxurUapD4= =MF5A -----END PGP SIGNATURE----- --aM3YZ0Iwxop3KEKx--