From: Shawn Guo <shawnguo@kernel.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH 4/5] ARM: dts: imx6ul-pico-hobbit: Extend peripherals support
Date: Thu, 6 Dec 2018 09:34:20 +0800 [thread overview]
Message-ID: <20181206013419.GT3987@dragon> (raw)
In-Reply-To: <20181202211809.11621-5-otavio@ossystems.com.br>
On Sun, Dec 02, 2018 at 07:18:08PM -0200, Otavio Salvador wrote:
> From: Fabio Estevam <festevam@gmail.com>
>
> This adds following peripherals support:
>
> - ADC
> - GPIO LED
> - GPIOs
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
> arch/arm/boot/dts/imx6ul-pico-hobbit.dts | 30 ++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
> index 8656ccbb5a06..f2dd6945e98c 100644
> --- a/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
> +++ b/arch/arm/boot/dts/imx6ul-pico-hobbit.dts
> @@ -14,6 +14,8 @@
>
> leds {
> compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_leds>;
>
> led {
> label = "gpio-led";
> @@ -58,6 +60,12 @@
> &i2c3 {
> status = "okay";
>
> + adc081c: adc@50 {
> + compatible = "ti,adc081c";
> + reg = <0x50>;
> + vref-supply = <®_3p3v>;
> + };
> +
The child nodes should be sorted in order of unit-address. That said,
it should go after touchscreen@38 below.
I fixed it up and applied the series.
Shawn
> polytouch: touchscreen@38 {
> compatible = "edt,edt-ft5x06";
> reg = <0x38>;
> @@ -68,3 +76,25 @@
> touchscreen-size-y = <480>;
> };
> };
> +
> +&iomuxc {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hog>;
> +
> + pinctrl_hog: hoggrp {
> + fsl,pins = <
> + MX6UL_PAD_CSI_VSYNC__GPIO4_IO19 0x10b0
> + MX6UL_PAD_CSI_DATA00__GPIO4_IO21 0x10b0
> + MX6UL_PAD_CSI_DATA01__GPIO4_IO22 0x10b0
> + MX6UL_PAD_CSI_DATA02__GPIO4_IO23 0x10b0
> + MX6UL_PAD_UART1_CTS_B__GPIO1_IO18 0x10b0
> + MX6UL_PAD_SNVS_TAMPER2__GPIO5_IO02 0x10b0
> + >;
> + };
> +
> + pinctrl_gpio_leds: gpioledsgrp {
> + fsl,pins = <
> + MX6UL_PAD_UART4_RX_DATA__GPIO1_IO29 0x10b0
> + >;
> + };
> +};
> --
> 2.19.2
>
next prev parent reply other threads:[~2018-12-06 1:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 21:18 [PATCH 0/5] Improvements for i.MX6UL PICO SoM and its baseboards Otavio Salvador
2018-12-02 21:18 ` [PATCH 1/5] ARM: dts: imx6ul-pico-hobbit: Switch to SPDX identifier Otavio Salvador
2018-12-02 21:18 ` [PATCH 2/5] ARM: dts: imx6ul-pico-hobbit: Move SoM related part to imx6ul-pico.dtsi Otavio Salvador
2018-12-02 21:18 ` [PATCH 3/5] ARM: dts: imx6ul-pico-hobbit: Make the child led nodes standard Otavio Salvador
2018-12-02 21:18 ` [PATCH 4/5] ARM: dts: imx6ul-pico-hobbit: Extend peripherals support Otavio Salvador
2018-12-06 1:34 ` Shawn Guo [this message]
2018-12-02 21:18 ` [PATCH 5/5] ARM: dts: imx6ul-pico: Add the imx6ul-pico-pi variant Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206013419.GT3987@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=otavio@ossystems.com.br \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).