* [PATCH V2 2/4] ARM: dts: imx6qdl-sabresd: add light sensor support
2018-12-06 1:42 [PATCH V2 1/4] ARM: dts: imx6qdl-sabresd: Move regulators outside of "simple-bus" Anson Huang
@ 2018-12-06 1:42 ` Anson Huang
2018-12-06 1:48 ` Fabio Estevam
2018-12-06 1:42 ` [PATCH V2 3/4] ARM: dts: imx6qdl-sabresd: add magnetometer " Anson Huang
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Anson Huang @ 2018-12-06 1:42 UTC (permalink / raw)
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, Fabio Estevam, robh+dt@kernel.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dl-linux-imx
Add isl29023 light sensor support on i2c3 bus, the light
sensor's power is controlled by a fixed regulator, since
the isl29023 driver and most of other sensors on same
board like mag3110 and mma8451 do NOT support regulator
operation currently, they are all controlled by this
regulator, so this patch also adds the fixed regulator
support and make it always on.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 66972e8..d07c250 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -54,6 +54,18 @@
enable-active-high;
};
+ reg_sensors: regulator-sensors {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_sensors_reg>;
+ regulator-name = "sensors-supply";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ regulator-always-on;
+ };
+
gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
@@ -410,6 +422,15 @@
interrupts = <7 2>;
wakeup-gpios = <&gpio6 7 0>;
};
+
+ light-sensor@44 {
+ compatible = "isil,isl29023";
+ reg = <0x44>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c3_isl29023_int>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
+ };
};
&iomuxc {
@@ -511,6 +532,12 @@
>;
};
+ pinctrl_i2c3_isl29023_int: i2c3isl29023intgrp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_DA9__GPIO3_IO09 0xb0b1
+ >;
+ };
+
pinctrl_ipu1_csi0: ipu1csi0grp {
fsl,pins = <
MX6QDL_PAD_CSI0_DAT12__IPU1_CSI0_DATA12 0x1b0b0
@@ -559,6 +586,12 @@
>;
};
+ pinctrl_sensors_reg: sensorsreggrp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_EB3__GPIO2_IO31 0x1b0b0
+ >;
+ };
+
pinctrl_uart1: uart1grp {
fsl,pins = <
MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0b1
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2 2/4] ARM: dts: imx6qdl-sabresd: add light sensor support
2018-12-06 1:42 ` [PATCH V2 2/4] ARM: dts: imx6qdl-sabresd: add light sensor support Anson Huang
@ 2018-12-06 1:48 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-12-06 1:48 UTC (permalink / raw)
To: Yongcai Huang
Cc: Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, NXP Linux Team
On Wed, Dec 5, 2018 at 11:43 PM Anson Huang <anson.huang@nxp.com> wrote:
>
> Add isl29023 light sensor support on i2c3 bus, the light
> sensor's power is controlled by a fixed regulator, since
> the isl29023 driver and most of other sensors on same
> board like mag3110 and mma8451 do NOT support regulator
> operation currently, they are all controlled by this
> regulator, so this patch also adds the fixed regulator
> support and make it always on.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 3/4] ARM: dts: imx6qdl-sabresd: add magnetometer sensor support
2018-12-06 1:42 [PATCH V2 1/4] ARM: dts: imx6qdl-sabresd: Move regulators outside of "simple-bus" Anson Huang
2018-12-06 1:42 ` [PATCH V2 2/4] ARM: dts: imx6qdl-sabresd: add light sensor support Anson Huang
@ 2018-12-06 1:42 ` Anson Huang
2018-12-06 1:42 ` [PATCH V2 4/4] ARM: dts: imx6qdl-sabresd: add accelerometer " Anson Huang
2018-12-06 7:48 ` [PATCH V2 1/4] ARM: dts: imx6qdl-sabresd: Move regulators outside of "simple-bus" Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Anson Huang @ 2018-12-06 1:42 UTC (permalink / raw)
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, Fabio Estevam, robh+dt@kernel.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dl-linux-imx
Add magnetometer sensor mag3110 support on i2c3 bus.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index d07c250..b8a2fd8 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -423,6 +423,15 @@
wakeup-gpios = <&gpio6 7 0>;
};
+ magnetometer@e {
+ compatible = "fsl,mag3110";
+ reg = <0x0e>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c3_mag3110_int>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <16 IRQ_TYPE_EDGE_RISING>;
+ };
+
light-sensor@44 {
compatible = "isil,isl29023";
reg = <0x44>;
@@ -538,6 +547,12 @@
>;
};
+ pinctrl_i2c3_mag3110_int: i2c3mag3110intgrp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D16__GPIO3_IO16 0xb0b1
+ >;
+ };
+
pinctrl_ipu1_csi0: ipu1csi0grp {
fsl,pins = <
MX6QDL_PAD_CSI0_DAT12__IPU1_CSI0_DATA12 0x1b0b0
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2 4/4] ARM: dts: imx6qdl-sabresd: add accelerometer sensor support
2018-12-06 1:42 [PATCH V2 1/4] ARM: dts: imx6qdl-sabresd: Move regulators outside of "simple-bus" Anson Huang
2018-12-06 1:42 ` [PATCH V2 2/4] ARM: dts: imx6qdl-sabresd: add light sensor support Anson Huang
2018-12-06 1:42 ` [PATCH V2 3/4] ARM: dts: imx6qdl-sabresd: add magnetometer " Anson Huang
@ 2018-12-06 1:42 ` Anson Huang
2018-12-06 7:48 ` [PATCH V2 1/4] ARM: dts: imx6qdl-sabresd: Move regulators outside of "simple-bus" Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Anson Huang @ 2018-12-06 1:42 UTC (permalink / raw)
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, Fabio Estevam, robh+dt@kernel.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dl-linux-imx
Add accelerometer sensor mma8451 support on i2c1 bus.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index b8a2fd8..174db44 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -242,6 +242,15 @@
>;
};
+ accelerometer@1c {
+ compatible = "fsl,mma8451";
+ reg = <0x1c>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c1_mma8451_int>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <18 IRQ_TYPE_LEVEL_LOW>;
+ };
+
ov5642: camera@3c {
compatible = "ovti,ov5642";
pinctrl-names = "default";
@@ -521,6 +530,12 @@
>;
};
+ pinctrl_i2c1_mma8451_int: i2c1mma8451intgrp {
+ fsl,pins = <
+ MX6QDL_PAD_SD1_CMD__GPIO1_IO18 0xb0b1
+ >;
+ };
+
pinctrl_i2c2: i2c2grp {
fsl,pins = <
MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b8b1
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2 1/4] ARM: dts: imx6qdl-sabresd: Move regulators outside of "simple-bus"
2018-12-06 1:42 [PATCH V2 1/4] ARM: dts: imx6qdl-sabresd: Move regulators outside of "simple-bus" Anson Huang
` (2 preceding siblings ...)
2018-12-06 1:42 ` [PATCH V2 4/4] ARM: dts: imx6qdl-sabresd: add accelerometer " Anson Huang
@ 2018-12-06 7:48 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-12-06 7:48 UTC (permalink / raw)
To: Anson Huang
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dl-linux-imx
On Thu, Dec 06, 2018 at 01:42:30AM +0000, Anson Huang wrote:
> From: Fabio Estevam <festevam@gmail.com>
>
> It is not recommended to place regulators inside "simple-bus", so move
> them out to make it cleaner the addition of new regulators.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied all, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread