From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based) Date: Thu, 6 Dec 2018 09:22:55 +0100 Message-ID: <20181206092255.2359f7e6@jawa> References: <20180921152726.31742-1-lukma@denx.de> <20181009105028.17971-1-lukma@denx.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/fNAwIrkEodxHoPV9nxRzz8E"; protocol="application/pgp-signature" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fabio Estevam Cc: Rob Herring , Shawn Guo , Mark Rutland , Sascha Hauer , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sascha Hauer , Stefan Agner , Fabio Estevam List-Id: devicetree@vger.kernel.org --Sig_/fNAwIrkEodxHoPV9nxRzz8E Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 5 Dec 2018 21:12:46 -0200 Fabio Estevam wrote: > Hi Lukasz/Rob, >=20 > On Tue, Oct 9, 2018 at 7:50 AM Lukasz Majewski wrote: >=20 > > +&dspi3 { > > + pinctrl-names =3D "default"; > > + pinctrl-0 =3D <&pinctrl_dspi3>; > > + bus-num =3D <3>; > > + status =3D "okay"; > > + spi-slave; > > + > > + slave@0 { > > + compatible =3D "lwn,bk4"; > > + spi-max-frequency =3D <30000000>; > > + reg =3D <0>; > > + }; > > +}; =20 >=20 > This is causing the following dtc warning in linux-next: >=20 > DTC arch/arm/boot/dts/vf610-bk4.dtb > arch/arm/boot/dts/vfxxx.dtsi:550.24-563.6: Warning (spi_bus_bridge): > /soc/aips-bus@40080000/spi@400ad000: incorrect #address-cells for SPI > bus > also defined at arch/arm/boot/dts/vf610-bk4.dts:106.8-118.3 > arch/arm/boot/dts/vf610-bk4.dtb: Warning (spi_bus_reg): Failed > prerequisite 'spi_bus_bridge' >=20 > If spi-slave property is removed the warning is gone. The spi-slave has been added according to review suggestion: https://lkml.org/lkml/2018/9/26/836 That is the way to handle "slave" SPI operation mode across the kernel.=20 At the time of development - I've checked my NXP related patches with W=3D1 passed to make. No warnings observed then. >=20 > Looking at drivers/spi/spi-fsl-dspi.c I don't see the "spi-slave" > property being handled there. >=20 > Any ideas on how to fix this? The *.dts file for Vybrid was sent and work on in parallel with the SPI slave code implementation for Vybrid: https://patchwork.kernel.org/patch/10680431/ Unfortunately, for the above patch I did not received any feedback since mid September. >=20 > Thanks Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/fNAwIrkEodxHoPV9nxRzz8E Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAlwI3F8ACgkQAR8vZIA0 zr1XwAf6AzT3SWC4ta3Q1VnPdsJTyE+ICHtxvUx2K7CwI8Nr5Ccu05Z0X6SxIaKJ I+IcpI9ywCPueOlcl1+ltTHGXY+K2xkQLqhqlPuWA7jWgkPIN56pXVD1ncB4+6LV i9AR1KpaAM9MwJDzVx9wbP4wjOgNqi1jqfkFJ0T9goyC6zcjTNPFrU847krUGu+D T9jO01LSxD3qszbIPEqfhoXF5VsE61oChuD0tmLJmerFP0+nJ2lXIN7pq1c80XBp dPpRl7vWGjyc353QpaOp09re5iiYHzRihKvpLlgQeZqOz47UnL8/8YjI+dPHFgud aqQW5e36WOm+E6Nn1tY4lszaIPredg== =MIct -----END PGP SIGNATURE----- --Sig_/fNAwIrkEodxHoPV9nxRzz8E--