From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
sakari.ailus@linux.intel.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rui Miguel Silva <rui.silva@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver
Date: Fri, 7 Dec 2018 16:38:49 +0300 [thread overview]
Message-ID: <20181207133849.GK3095@unbuntlaptop> (raw)
In-Reply-To: <757f8c52-7c23-7cf7-32ee-75ddba767ff8@xs4all.nl>
On Fri, Dec 07, 2018 at 01:44:00PM +0100, Hans Verkuil wrote:
> CHECK: Alignment should match open parenthesis
> #936: FILE: drivers/staging/media/imx/imx7-mipi-csis.c:921:
> + ret = v4l2_async_register_fwnode_subdev(mipi_sd,
> + sizeof(struct v4l2_async_subdev), &sink_port, 1,
>
> Apparently the latest coding style is that alignment is more important than
> line length, although I personally do not agree. But since you need to
> respin in any case due to the wrong SPDX identifier you used you might as
> well take this into account.
I'm pretty sure it complains about both equally. If you make fix one
warning it will complain about the other. So you just have to pick
which warning to not care about.
regards,
dan carpenter
next prev parent reply other threads:[~2018-12-07 13:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 15:18 [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 01/13] media: staging/imx: refactor imx media device probe Rui Miguel Silva
2018-12-07 12:38 ` Hans Verkuil
2018-12-07 13:53 ` Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 02/13] media: staging/imx: rearrange group id to take in account IPU Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 03/13] media: staging/imx7: add imx7 CSI subdev driver Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 04/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7 Rui Miguel Silva
2018-12-03 12:10 ` Sakari Ailus
2018-12-05 9:48 ` Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver Rui Miguel Silva
2018-12-07 12:39 ` Hans Verkuil
2018-12-07 13:54 ` Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 06/13] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 07/13] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 10/13] media: imx7.rst: add documentation for i.MX7 media driver Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 11/13] media: staging/imx: add i.MX7 entries to TODO file Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 12/13] media: video-mux: add bayer formats Rui Miguel Silva
2018-11-22 15:18 ` [PATCH v9 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver Rui Miguel Silva
2018-12-07 12:44 ` [PATCH v9 00/13] media: staging/imx7: add " Hans Verkuil
2018-12-07 13:38 ` Dan Carpenter [this message]
2018-12-07 14:01 ` Rui Miguel Silva
2019-01-18 16:49 ` Fabio Estevam
2019-01-18 18:28 ` Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207133849.GK3095@unbuntlaptop \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rui.silva@linaro.org \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox