devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: omap5: Fix dual-role mode on Super-Speed port
@ 2018-12-05 17:27 Roger Quadros
  2018-12-07 16:25 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Roger Quadros @ 2018-12-05 17:27 UTC (permalink / raw)
  To: tony; +Cc: robh+dt, hns, linux-omap, devicetree, linux-kernel, Roger Quadros

OMAP5's Super-Speed USB port has a software mailbox register
that needs to be fed with VBUS and ID events from an external
VBUS/ID comparator.

Without this, Host role will not work correctly.

Fixes: 656c1a65ab55 ("ARM: dts: omap5: enable OTG role for DWC3 controller")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---

Tony,

Please included this in v4.20-rc cycle. Thanks.

cheers,
-roger

 arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index bf7ca00..bc853eb 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi
@@ -701,6 +701,7 @@
 };
 
 &dwc3 {
+	extcon = <&extcon_usb3>;
 	dr_mode = "otg";
 };
 
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: omap5: Fix dual-role mode on Super-Speed port
  2018-12-05 17:27 [PATCH] ARM: dts: omap5: Fix dual-role mode on Super-Speed port Roger Quadros
@ 2018-12-07 16:25 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2018-12-07 16:25 UTC (permalink / raw)
  To: Roger Quadros; +Cc: robh+dt, hns, linux-omap, devicetree, linux-kernel

* Roger Quadros <rogerq@ti.com> [181205 17:28]:
> OMAP5's Super-Speed USB port has a software mailbox register
> that needs to be fed with VBUS and ID events from an external
> VBUS/ID comparator.
> 
> Without this, Host role will not work correctly.
> 
> Fixes: 656c1a65ab55 ("ARM: dts: omap5: enable OTG role for DWC3 controller")
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> 
> Tony,
> 
> Please included this in v4.20-rc cycle. Thanks.

Applying into omap-for-v4.20/fixes.

Thanks,

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-07 16:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-05 17:27 [PATCH] ARM: dts: omap5: Fix dual-role mode on Super-Speed port Roger Quadros
2018-12-07 16:25 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).