* [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock
[not found] <1544182066-31528-1-git-send-email-biju.das@bp.renesas.com>
@ 2018-12-07 11:27 ` Biju Das
2018-12-07 23:19 ` Rob Herring
` (2 more replies)
2018-12-07 11:27 ` [PATCH v4 5/5] ARM: dts: iwg23s-sbc: Enable RTC Biju Das
1 sibling, 3 replies; 6+ messages in thread
From: Biju Das @ 2018-12-07 11:27 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Geert Uytterhoeven,
Rob Herring, Mark Rutland
Cc: Biju Das, linux-rtc, devicetree, Simon Horman, Chris Paterson,
Srinivas Kandagatla, Fabrizio Castro, linux-renesas-soc
The pcf85263 RTC is compatible with the pcf85363 RTC.
The difference between the pcf85263 and pcf85363 RTC is that the latter has
64 bytes more RAM. This renders them incompatible from a DT point of view.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
V1-->V2
* Incorporated Simon's review comment.
V2-->V3
* No Change.
V3-->V4
* No Change.
---
Documentation/devicetree/bindings/rtc/pcf85363.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt
index 76fdabc..94adc1c 100644
--- a/Documentation/devicetree/bindings/rtc/pcf85363.txt
+++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt
@@ -1,8 +1,8 @@
-NXP PCF85363 Real Time Clock
+NXP PCF85263/PCF85363 Real Time Clock
============================
Required properties:
-- compatible: Should contain "nxp,pcf85363".
+- compatible: Should contain "nxp,pcf85263" or "nxp,pcf85363".
- reg: I2C address for chip.
Optional properties:
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4 5/5] ARM: dts: iwg23s-sbc: Enable RTC
[not found] <1544182066-31528-1-git-send-email-biju.das@bp.renesas.com>
2018-12-07 11:27 ` [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock Biju Das
@ 2018-12-07 11:27 ` Biju Das
2018-12-10 12:15 ` Simon Horman
1 sibling, 1 reply; 6+ messages in thread
From: Biju Das @ 2018-12-07 11:27 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, Alexandre Belloni,
Srinivas Kandagatla, linux-rtc, linux-renesas-soc, devicetree,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
V1-->V2
* No change
V2-->V3
* No change
V3-->V4
* No change
---
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index 40b7f98..77d1824 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -84,12 +84,30 @@
clock-frequency = <20000000>;
};
+&i2c3 {
+ pinctrl-0 = <&i2c3_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+ clock-frequency = <400000>;
+
+ rtc@51 {
+ compatible = "nxp,pcf85263";
+ reg = <0x51>;
+ };
+};
+
&pfc {
avb_pins: avb {
groups = "avb_mdio", "avb_gmii_tx_rx";
function = "avb";
};
+ i2c3_pins: i2c3 {
+ groups = "i2c3_c";
+ function = "i2c3";
+ };
+
mmc_pins_uhs: mmc_uhs {
groups = "mmc_data8", "mmc_ctrl";
function = "mmc";
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock
2018-12-07 11:27 ` [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock Biju Das
@ 2018-12-07 23:19 ` Rob Herring
2018-12-10 12:16 ` Simon Horman
2018-12-11 11:15 ` Alexandre Belloni
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2018-12-07 23:19 UTC (permalink / raw)
To: Biju Das
Cc: Alessandro Zummo, Alexandre Belloni, Geert Uytterhoeven,
Mark Rutland, linux-rtc, devicetree, Simon Horman, Chris Paterson,
Srinivas Kandagatla, Fabrizio Castro, linux-renesas-soc
On Fri, 7 Dec 2018 11:27:43 +0000, Biju Das wrote:
> The pcf85263 RTC is compatible with the pcf85363 RTC.
>
> The difference between the pcf85263 and pcf85363 RTC is that the latter has
> 64 bytes more RAM. This renders them incompatible from a DT point of view.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> V1-->V2
> * Incorporated Simon's review comment.
> V2-->V3
> * No Change.
> V3-->V4
> * No Change.
> ---
> Documentation/devicetree/bindings/rtc/pcf85363.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 5/5] ARM: dts: iwg23s-sbc: Enable RTC
2018-12-07 11:27 ` [PATCH v4 5/5] ARM: dts: iwg23s-sbc: Enable RTC Biju Das
@ 2018-12-10 12:15 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2018-12-10 12:15 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Magnus Damm, Alexandre Belloni,
Srinivas Kandagatla, linux-rtc, linux-renesas-soc, devicetree,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Fri, Dec 07, 2018 at 11:27:46AM +0000, Biju Das wrote:
> Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied for v4.22.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock
2018-12-07 11:27 ` [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock Biju Das
2018-12-07 23:19 ` Rob Herring
@ 2018-12-10 12:16 ` Simon Horman
2018-12-11 11:15 ` Alexandre Belloni
2 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2018-12-10 12:16 UTC (permalink / raw)
To: Biju Das
Cc: Alessandro Zummo, Alexandre Belloni, Geert Uytterhoeven,
Rob Herring, Mark Rutland, linux-rtc, devicetree, Chris Paterson,
Srinivas Kandagatla, Fabrizio Castro, linux-renesas-soc
On Fri, Dec 07, 2018 at 11:27:43AM +0000, Biju Das wrote:
> The pcf85263 RTC is compatible with the pcf85363 RTC.
>
> The difference between the pcf85263 and pcf85363 RTC is that the latter has
> 64 bytes more RAM. This renders them incompatible from a DT point of view.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock
2018-12-07 11:27 ` [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock Biju Das
2018-12-07 23:19 ` Rob Herring
2018-12-10 12:16 ` Simon Horman
@ 2018-12-11 11:15 ` Alexandre Belloni
2 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2018-12-11 11:15 UTC (permalink / raw)
To: Biju Das
Cc: Alessandro Zummo, Geert Uytterhoeven, Rob Herring, Mark Rutland,
linux-rtc, devicetree, Simon Horman, Chris Paterson,
Srinivas Kandagatla, Fabrizio Castro, linux-renesas-soc
On 07/12/2018 11:27:43+0000, Biju Das wrote:
> The pcf85263 RTC is compatible with the pcf85363 RTC.
>
> The difference between the pcf85263 and pcf85363 RTC is that the latter has
> 64 bytes more RAM. This renders them incompatible from a DT point of view.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> V1-->V2
> * Incorporated Simon's review comment.
> V2-->V3
> * No Change.
> V3-->V4
> * No Change.
> ---
> Documentation/devicetree/bindings/rtc/pcf85363.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-11 11:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1544182066-31528-1-git-send-email-biju.das@bp.renesas.com>
2018-12-07 11:27 ` [PATCH v4 2/5] dt-bindings: rtc: pcf85363: Document pcf85263 real-time clock Biju Das
2018-12-07 23:19 ` Rob Herring
2018-12-10 12:16 ` Simon Horman
2018-12-11 11:15 ` Alexandre Belloni
2018-12-07 11:27 ` [PATCH v4 5/5] ARM: dts: iwg23s-sbc: Enable RTC Biju Das
2018-12-10 12:15 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).