From: Rob Herring <robh@kernel.org>
To: PETER CHEN <peter.chen@nxp.com>
Cc: Schrempf Frieder <frieder.schrempf@kontron.de>,
Fabio Estevam <festevam@gmail.com>,
USB list <linux-usb@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Schrempf Frieder <frieder.schrempf@exceet.de>
Subject: Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
Date: Fri, 7 Dec 2018 17:32:34 -0600 [thread overview]
Message-ID: <20181207233234.GA1419@bogus> (raw)
In-Reply-To: <VI1PR04MB532787E6EF89EBFAAE052A0C8BA80@VI1PR04MB5327.eurprd04.prod.outlook.com>
On Wed, Dec 05, 2018 at 07:57:37AM +0000, PETER CHEN wrote:
>
> > On 04.12.18 21:01, Fabio Estevam wrote:
> > > Hi Frieder,
> > >
> > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder
> > > <frieder.schrempf@kontron.de> wrote:
> > >
> > >> There are many other optional properties for this driver and a lot of
> > >> them are not in the given example. Maybe we should just keep the
> > >> pinctrls for HSIC-mode out of the example, too?
> > >
> > > I am just trying to make life easier for those who want to use HSIC
> > > support with chipidea.
> > >
> > > Can we just add a real dts snippet example of your board into the
> > > binding document?
> >
> > Sure, here is what I have in my dts:
> >
> > &usbh2 {
> > pinctrl-names = "idle", "active";
> > pinctrl-0 = <&pinctrl_usbh2_idle>;
> > pinctrl-1 = <&pinctrl_usbh2_active>;
> > status = "okay";
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > usbnet: smsc@1 {
> > compatible = "usb424,9730";
> > reg = <1>;
> > };
> > };
> >
> > @Peter: Can you add this as a second example to the binding documentation?
> >
>
> So, there are two examples at binding-doc, one for normal, one for HSIC? Fabio, do you
> mean that? If DT maintainer agrees it too, I will add it.
Okay.
next prev parent reply other threads:[~2018-12-07 23:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 9:30 [PATCH v3 0/4] usb: chipidea: imx: add HSIC support PETER CHEN
2018-11-27 9:30 ` [PATCH v3 1/4] usb: chipidea: add flag for imx hsic implementation PETER CHEN
2018-11-27 13:40 ` Schrempf Frieder
2018-11-27 9:30 ` [PATCH v3 2/4] usb: chipidea: imx: add HSIC support PETER CHEN
2018-11-27 13:41 ` Schrempf Frieder
2018-11-27 9:30 ` [PATCH v3 3/4] usb: chipidea: host: override ehci->hub_control PETER CHEN
2018-11-27 13:41 ` Schrempf Frieder
2018-11-30 2:43 ` PETER CHEN
2018-11-27 9:31 ` [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups PETER CHEN
2018-11-27 11:09 ` Fabio Estevam
2018-11-30 2:33 ` PETER CHEN
2018-12-04 14:31 ` Schrempf Frieder
2018-12-04 20:01 ` Fabio Estevam
2018-12-05 7:45 ` Schrempf Frieder
2018-12-05 7:57 ` PETER CHEN
2018-12-05 11:10 ` Fabio Estevam
2018-12-07 23:32 ` Rob Herring [this message]
2018-12-05 8:00 ` Schrempf Frieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207233234.GA1419@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@exceet.de \
--cc=frieder.schrempf@kontron.de \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).