From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 7 Dec 2018 17:32:34 -0600 From: Rob Herring Subject: Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Message-ID: <20181207233234.GA1419@bogus> References: <20181127092824.22756-1-peter.chen@nxp.com> <20181127092824.22756-5-peter.chen@nxp.com> <0215e99c-c024-42f6-9dad-4bab70bae193@kontron.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: PETER CHEN Cc: Schrempf Frieder , Fabio Estevam , USB list , dl-linux-imx , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Schrempf Frieder List-ID: On Wed, Dec 05, 2018 at 07:57:37AM +0000, PETER CHEN wrote: > > > On 04.12.18 21:01, Fabio Estevam wrote: > > > Hi Frieder, > > > > > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder > > > wrote: > > > > > >> There are many other optional properties for this driver and a lot of > > >> them are not in the given example. Maybe we should just keep the > > >> pinctrls for HSIC-mode out of the example, too? > > > > > > I am just trying to make life easier for those who want to use HSIC > > > support with chipidea. > > > > > > Can we just add a real dts snippet example of your board into the > > > binding document? > > > > Sure, here is what I have in my dts: > > > > &usbh2 { > > pinctrl-names = "idle", "active"; > > pinctrl-0 = <&pinctrl_usbh2_idle>; > > pinctrl-1 = <&pinctrl_usbh2_active>; > > status = "okay"; > > #address-cells = <1>; > > #size-cells = <0>; > > > > usbnet: smsc@1 { > > compatible = "usb424,9730"; > > reg = <1>; > > }; > > }; > > > > @Peter: Can you add this as a second example to the binding documentation? > > > > So, there are two examples at binding-doc, one for normal, one for HSIC? Fabio, do you > mean that? If DT maintainer agrees it too, I will add it. Okay.