From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803 Date: Sat, 8 Dec 2018 16:05:26 +0100 Message-ID: <20181208150526.uceviwfwqskfwovm@qschulz> References: <20181120175211.3913-1-oskari@lemmela.net> <20181120175211.3913-9-oskari@lemmela.net> <20181207164011.GI26661@dell> <20181207192237.GK26661@dell> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="umq566xyw5pxyboh" Return-path: Content-Disposition: inline In-Reply-To: <20181207192237.GK26661@dell> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: Vasily Khoruzhick , Oskari Lemmela , Sebastian Reichel , Rob Herring , Mark Rutland , Chen-Yu Tsai , Maxime Ripard , linux-pm@vger.kernel.org, devicetree , linux-kernel , arm-linux List-Id: devicetree@vger.kernel.org --umq566xyw5pxyboh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Lee, On Fri, Dec 07, 2018 at 07:22:37PM +0000, Lee Jones wrote: > On Fri, 07 Dec 2018, Vasily Khoruzhick wrote: >=20 > > On Fri, Dec 7, 2018 at 8:40 AM Lee Jones wrote: > >=20 > > > My OCD-dar is going crazy. > > > > > > Why haven't you used the same alignment as is already there? > > > > > > If it starts to run over 80-chars then bring the others back. > > > > > > Also why is there a single liner shoved in the middle of the > > > multi-line entries? Please move the singles to the top or the > > > bottom. > >=20 > > Hi Lee, > >=20 > > Could you please reformat it in the way that makes your OCD-dar happy? > > It would be really nice to get >=20 > I'm afraid not, for a multitude of reasons. >=20 > The most important of which surround testing. >=20 > > AC and battery support for APX8x3 merged -- it'll make Pinebook and > > Teres-I pretty well supported by mainline kernel. >=20 > That's great. A worthy cause indeed. So I'm sure you guys will want > to turn the patch around in short order so that it's applied in time > for the next merge window. >=20 Aren't the MFD cells probed in order? In that case, it makes little sense to short order them for this particular device (X-Powers PMICs in general). It will just make the system boot slower because of probe deferring. Why? As explained by Chen-Yu in v3[1], axp-gpios can be muxed as regulators, thus should be probed before axp-regulators. axp-adc is often used by axp-battery, axp-usb-power, axp-ac-power, thus should be probed beforehand as well. For the alignment that also triggered your OCD, I can send you a patch the day you merge this one if it can help. I sent a few patches for this driver that didn't respect the alignment so I'm fine fixing the mfd cells (and eventually re-order them as I saw a few axp-gpio cells being declared after axp-regulators). Does that make this patch OK for you, Lee? Thanks, Quentin [1] https://lkml.org/lkml/2018/10/11/338 --umq566xyw5pxyboh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEXeEYjDsJh38OoyMzhLiadT7g8aMFAlwL3bYACgkQhLiadT7g 8aMzDQ//SP/WNuKOA5RABdv9owyD0gfaSWiEML1W6ovmeEBPfxP6euZcHgnRsgEw errjVUNOrlUy1Dn7cDLMhhCYlZuXBjfqlakVRAZpzhI1n0C4jHcERSB5e7Qck9uf UwUSmi5rRZF0s2Tk034O/ycv/BkbRbXwPKN9K5j9zsyGYXBjWlw7Vr695E4O9pSc 69dTwRq1eYUFXlOk6Z8jBwAbMfPq38MgT7TbOq6OhxfW7efsPF4GinGyFfmhYmd/ C8uJtc+NxXn3XOySpObEAIbl5XL+ugpwT/zVhGz+IdNBX+aJNLWrzpyfK/9U9DEd TQye0ezWR8n4navDsuYfYMaPXToXRZRWc/m1yvM+mSkDOAiXBhNZ1+oUPRTiKtnS fxx+THTvpUwmNACctbUNRoU5u4QHfyL5A4I3uuiPyU9x3c9WYnB/ycHBxgMVx/0A QrH7czW0VeqI598UV7hfNmDwV74ZxcJvCdROQLr5i9KWqknjTYAizvJdK/76MxSh fAkA+SHO55y22ivHeJsCha6cIOtbbOVzVjFLeDRm+1MiHNFkacNHglNtC030hE1Z LYjKE2hdG8zlL1Ak78Fpam9mZrOtHpwbS+AJpNsdZFA455iqZQfsLI6CY7o/N6E5 t739gtE19+hwYyaK2cNG9F4eZkVrtnOyNkOMxX1yIUkeMoRHUAE= =BKmW -----END PGP SIGNATURE----- --umq566xyw5pxyboh--