From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/8] Input: tm2-touchkey: Use predefined device name Date: Sat, 8 Dec 2018 20:23:38 -0800 Message-ID: <20181209042338.GC211094@dtor-ws> References: <20181207105811.1831-1-pawel.mikolaj.chmiel@gmail.com> <20181207105811.1831-4-pawel.mikolaj.chmiel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20181207105811.1831-4-pawel.mikolaj.chmiel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: =?utf-8?B?UGF3ZcWC?= Chmiel Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, xc-racer2@live.ca, simon@lineageos.org List-Id: devicetree@vger.kernel.org On Fri, Dec 07, 2018 at 11:58:06AM +0100, Paweł Chmiel wrote: > From: Jonathan Bakker > > Purely a cosmetic fix, using the names defined earlier If we decide to keep different names please fold into first patch. > > Signed-off-by: Jonathan Bakker > Signed-off-by: Paweł Chmiel > --- > drivers/input/keyboard/tm2-touchkey.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c > index 37a5ced24009..cc713b901bf2 100644 > --- a/drivers/input/keyboard/tm2-touchkey.c > +++ b/drivers/input/keyboard/tm2-touchkey.c > @@ -57,13 +57,13 @@ struct tm2_touchkey_data { > }; > > static struct touchkey_variant tm2_touchkey_variant = { > - .name = "tm2-touchkey", > + .name = TM2_TOUCHKEY_DEV_NAME, > .keycode_reg = 0x03, > .base_reg = 0x00, > }; > > static struct touchkey_variant midas_touchkey_variant = { > - .name = "midas-touchkey", > + .name = MIDAS_TOUCHKEY_DEV_NAME, > .keycode_reg = 0x00, > .base_reg = 0x00, > }; > -- > 2.17.1 > -- Dmitry