Re: [PATCH 4/4] ARM: dts: imx7d: sbc imx7: add uart5

[Shawn Guo <shawnguo@kernel.org>]

On Mon, Dec 10, 2018 at 09:43:12AM -0200, Fabio Estevam wrote:
> Hi Hans,
> 
> On Mon, Dec 10, 2018 at 8:52 AM Hans Ole Hatzel <hohatzel@jusst.de> wrote:
> 
> > imx7d-pico.dts does this the same way. Is that good enough of a reason?
> > If so, should it be included in the commit message?
> 
> The UART clock parent initialization has been removed from the imx7d
> clock driver since commit (in linux-next):
> 
> commit ea662d2f804ad13c3c92c75c7dc1abad30e31c31
> Author: Anson Huang <anson.huang@nxp.com>
> Date:   Fri Oct 19 01:05:36 2018 +0000
> 
>     clk: imx7d: remove UART1 clock setting
> 
>     There are clock assignments in all i.MX7D dtb files for UART1,
>     below is the example in imx7d-sdb.dts, so setting UART1 clock
>     in clock driver is NOT necessary, actually, module clocks setting
>     should be done in module driver.
> 
>     &uart1 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_uart1>;
>         assigned-clocks = <&clks IMX7D_UART1_ROOT_SRC>;
>         assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
>         status = "okay";
>     };
> 
>     Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>     Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> 
> So the UART clock parent should be set in the device tree.

Okay, but would it be better to set the default parent clock in soc
level of dtsi, since the configuration doesn't seem to be board
specific?

Shawn