From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller Date: Tue, 11 Dec 2018 22:45:27 +0100 Message-ID: <20181211214527.GA5660@kunai> References: <1543489197-183181-1-git-send-email-jian.hu@amlogic.com> <8a6a204b28523e5a181f9e85dda18fade76a26a3.camel@baylibre.com> <20181211203652.rogajl4ajwu7cs6f@ninjato> <7hsgz3u4fu.fsf@baylibre.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Return-path: Content-Disposition: inline In-Reply-To: <7hsgz3u4fu.fsf@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Kevin Hilman Cc: Jian Hu , Jerome Brunet , Neil Armstrong , Carlo Caione , Rob Herring , Martin Blumenstingl , Michael Turquette , Stephen Boyd , Mark Rutland , Jianxin Pan , Hanjie Lin , linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >> I am okay if it is reasonable below in file > >> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi. I2c controller node just = uses > >> axg's compatible. > >>=20 > >> i2c0: i2c@1f000 { > >> compatible =3D "amlogic,meson-axg-i2c"; > > > > Actually, you should have > > > > compatible =3D "amlogic,meson-g12a-i2c", "amlogic,meson-axg-i2c"; > > > > in the DT to have support for future SoC specific additions. And then, > > patch 1 is needed. > > > > Or do you handle this differently? I'd think this is DT standard. >=20 > It's a DT standard *if* there are actual hardware differences. In this > case, the IP block is identical, so there are no driver changes. >=20 > We prefer to add a new compatible if and when there are actual > driver/hardware changes. OK, fine with me. I just hope for you guys that there really is no change in the IP block, otherwise you need to update DTs later. --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlwQL/IACgkQFA3kzBSg KbbXFg//SIq2lU0nge0Dh0BSX8NJGPF/ETdhp8hcEKs5kManXc/Kd+rLlNJC7y84 AMSGX9pIK899f51uMMgI6AbzNGimTk8Y2nghiHLyq6tum6QeFdOIjDJOC3lICUhx z7L+BEZ6hFNJPBZRSCRlio3dag2k8qHhM5ah6Xu6i7mH+g1JrNi6gFyrZsNv8hFy 3Hg/bL7DwZXQJFknp0tsOglXiJThOz7VDx460zqn5cyl2PRvSaRvhZ67Yzg9I7Sz TQIW+KLj/hv2JApKkJtlYFHit+p3ZZvb/JfaGfO2FsKnBL6WJQJT6dLwPiK1guG7 wSmp3eOqAlgeI3NMNqmAy2SfYqZn3IoVsuNy9us5+hkshxwsgOxkoT1Vvde3o19b c42k8bolyzyvdKDGbl1UuahvQLB3pdYvDa1kCzO63BlW6slMVsjhcYuK0yP7AW7F 4SSumOdaFrd3azSi7pl5eG21J19U45sSxWow9oMRuw9yW9JHDiB5mIKt4dLTIym/ mAbfHswdxtRDepqmM2UyLRN5RX6bJA8aefum/2jdNg98dbiUHMX8akHqbS//eiOX xBZcptougATsy9JIVcw25PSpg0NTUM4udScSsKyptNTFkFoE6PyF7ln67R8M3R2n uTW6i946iQ/olPGPhN/yCWg3AoD9mAdaxEOIcGZ3ekgA94NbgUc= =J9xG -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI--