From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding Date: Tue, 11 Dec 2018 16:11:26 -0600 Message-ID: <20181211221126.GA12250@bogus> References: <20181127074249.15204-1-icenowy@aosc.io> <20181127074249.15204-2-icenowy@aosc.io> Reply-To: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20181127074249.15204-2-icenowy-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Jernej Skrabec , Chen-Yu Tsai , Maxime Ripard , David Airlie , Mark Rutland , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Nov 27, 2018 at 03:42:49PM +0800, Icenowy Zheng wrote: > Allwinner H6 SoC uses a Mali T720 GPU, which is one of the GPUs in the > Midgard GPU product line. > > Add binding for the H6 Mali Midgard GPU. > > Signed-off-by: Icenowy Zheng > --- > .../devicetree/bindings/gpu/arm,mali-midgard.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > index 02f870cd60e6..c897dd7be48f 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > @@ -18,6 +18,7 @@ Required properties: > + "amlogic,meson-gxm-mali" > + "rockchip,rk3288-mali" > + "rockchip,rk3399-mali" > + + "allwinner,sun50i-h6-mali" > > - reg : Physical base address of the device and length of the register area. > > @@ -44,6 +45,18 @@ Optional properties: > for details. > > > +Vendor-specific bindings > +------------------------ > + > +The Mali GPU is integrated very differently from one SoC to > +another. In order to accomodate those differences, you have the option WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? #50: FILE: Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt:52: > +to specify one more vendor-specific compatible, among: > + > + - allwinner,sun50i-h6-mali > + Required properties: > + * resets: phandle to the reset line for the GPU > + > + > Example for a Mali-T760: > > gpu@ffa30000 { > -- > 2.18.1 >