From: Greg KH <gregkh@linuxfoundation.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: robh+dt@kernel.org, arnd@arndb.de, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
bkumar@qti.qualcomm.com, thierry.escande@linaro.org
Subject: Re: [PATCH v2 3/6] misc: fastrpc: Add support for context Invoke method
Date: Wed, 12 Dec 2018 12:02:34 +0100 [thread overview]
Message-ID: <20181212110234.GB1990@kroah.com> (raw)
In-Reply-To: <20181207163513.16412-4-srinivas.kandagatla@linaro.org>
On Fri, Dec 07, 2018 at 04:35:10PM +0000, Srinivas Kandagatla wrote:
> +#define FASTRPC_BUILD_SCALARS(attr, method, in, out, oin, oout) \
> + ((((uint32_t) (attr) & 0x07) << 29) | \
> + (((uint32_t) (method) & 0x1f) << 24) | \
Why all of the uint32_t and uint64_t types in this patch, but not the
previous one?
Please just stick with u32 and u64, those are the correct kernel types
to be using everywhere. uint32_t and friends are userspace things that
make no sense in kernel space.
Yes, I know people use them, but we should not be adding to the problem
by creating new instances of them for no good reason.
thanks,
greg k-h
next prev parent reply other threads:[~2018-12-12 11:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 16:35 [PATCH v2 0/6] misc: Add support to Qualcomm FastRPC driver Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings Srinivas Kandagatla
2018-12-07 18:23 ` Mark Rutland
2018-12-10 11:17 ` Srinivas Kandagatla
2018-12-11 0:10 ` Bjorn Andersson
2018-12-11 9:27 ` Srinivas Kandagatla
2018-12-11 10:50 ` Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 2/6] misc: fastrpc: Add Qualcomm fastrpc basic driver model Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 3/6] misc: fastrpc: Add support for context Invoke method Srinivas Kandagatla
2018-12-10 14:55 ` kbuild test robot
2018-12-12 11:02 ` Greg KH [this message]
2018-12-12 11:14 ` Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 4/6] misc: fastrpc: Add support for create remote init process Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 5/6] misc: fastrpc: Add support for dmabuf exporter Srinivas Kandagatla
2018-12-07 16:35 ` [PATCH v2 6/6] misc: fastrpc: Add support for compat ioctls Srinivas Kandagatla
2018-12-12 10:59 ` Greg KH
2018-12-12 11:44 ` Srinivas Kandagatla
2018-12-12 11:50 ` Greg KH
2018-12-12 12:26 ` Srinivas Kandagatla
2018-12-12 13:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212110234.GB1990@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=bkumar@qti.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thierry.escande@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).