From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH V5 1/2] dt-bindings: iio: light: isl29018: update power supply name Date: Wed, 12 Dec 2018 17:04:25 +0000 Message-ID: <20181212170425.49658e0c@archlinux> References: <1544504196-30277-1-git-send-email-Anson.Huang@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1544504196-30277-1-git-send-email-Anson.Huang@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Anson Huang Cc: "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "festevam@gmail.com" , "preid@electromag.com.au" , dl-linux-imx List-Id: devicetree@vger.kernel.org On Tue, 11 Dec 2018 05:02:39 +0000 Anson Huang wrote: > According to datasheet, the isl29018 has "vddd/vdda" power > supply, the "vdda" and "vddd" MUST be shorted externally, > and isl29023/isl29035 ONLY has "vdd" power supply, so just > one regulator is needed for the driver, update the power > supply name with "vdd" according to datasheet to avoid > confusion. > > Signed-off-by: Anson Huang Given the discussion on v4 I am assuming this should be dropped. Shout if I'm missing something. Jonathan > --- > ChangeLog since V4: > Since ONLY isl29018 has two power supplies and they are MUST shorted externally, so they can be > treated as one power supply as well, remove "vdda" power supply and ONLY update the "vcc" with > "vdd" according to datasheet. > --- > Documentation/devicetree/bindings/iio/light/isl29018.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt b/Documentation/devicetree/bindings/iio/light/isl29018.txt > index b9bbde3..c4c4e9e 100644 > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt > @@ -15,7 +15,7 @@ Optional properties: > Refer to interrupt-controller/interrupts.txt for generic interrupt client > node bindings. > > - - vcc-supply: phandle to the regulator that provides power to the sensor. > + - vdd-supply: phandle to the regulator that provides power to the sensor. > > Example: >