From mboxrd@z Thu Jan 1 00:00:00 1970 From: Niklas Cassel Subject: Re: [PATCH v4 3/8] drm/msm/dsi: 28nm PHY: Get ref clock from the DT Date: Wed, 12 Dec 2018 23:07:17 +0100 Message-ID: <20181212220717.GA16710@centauri.lan> References: <20181204224234.62619-1-mka@chromium.org> <20181204224234.62619-4-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181204224234.62619-4-mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Matthias Kaehlcke Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Archit Taneja , Rajesh Yadav , David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Douglas Anderson , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Stephen Boyd , David Brown , Rob Clark , Rob Herring , Sean Paul , Andy Gross , Jeykumar Sankaran , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org T24gVHVlLCBEZWMgMDQsIDIwMTggYXQgMDI6NDI6MjlQTSAtMDgwMCwgTWF0dGhpYXMgS2FlaGxj a2Ugd3JvdGU6Cj4gR2V0IHRoZSByZWYgY2xvY2sgb2YgdGhlIFBIWSBmcm9tIHRoZSBkZXZpY2Ug dHJlZSBpbnN0ZWFkIG9mCj4gaGFyZGNvZGluZyBpdHMgbmFtZSBhbmQgcmF0ZS4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYXR0aGlhcyBLYWVobGNrZSA8bWthQGNocm9taXVtLm9yZz4KPiAtLS0KPiBD aGFuZ2VzIGluIHY0Ogo+IC0gYWx3YXlzIHVzZSBwYXJlbnQgcmF0ZSBpbiBkc2lfcGxsXzI4bm1f Y2xrX3NldF9yYXRlKCkgYW5kCj4gICAgZHNpX3BsbF8yOG5tX2Nsa19yZWNhbGNfcmF0ZSgpCj4g LSBwYXNzIG5hbWUgb2YgVkNPIHJlZiBjbG9jayB0byBwbGxfMjhubV9yZWdpc3RlcigpIGluc3Rl YWQgb2YKPiAgIHN0b3JpbmcgaXQgaW4gYSBzdHJ1Y3QgZmllbGQKPiAtIHVwZGF0ZWQgY29tbWl0 IG1lc3NhZ2UKPiAKPiBDaGFuZ2VzIGluIHYzOgo+IC0gdXNlIGRlZmF1bHQgbmFtZSBhbmQgcmF0 ZSBpZiB0aGUgcmVmIGNsb2NrIGlzIG5vdCBzcGVjaWZpZWQKPiAgIGluIHRoZSBEVAo+IC0gc3Rv cmUgdmNvX3JlZl9jbGtfbmFtZSBpbnN0ZWFkIG9mIHZjb19yZWZfY2xrCj4gLSBkc2lfcGxsXzI4 bm1fY2xrX3NldF9yYXRlOiBjaGFuZ2VkIGRhdGEgdHlwZSBvZiByZWZfY2xrX3JhdGUgdG8KPiAg IHVuc2lnbmVkIGxvbmcKPiAtIGZpeGVkIGNoZWNrIGZvciBFUFJPQkVfREVGRVIKPiAtIHJlbmFt ZWQgVkNPX1JFRl9DTEtfUkFURSB0byBWQ09fUkVGX0NMS19ERUZBVUxUX1JBVEUKPiAKPiBDaGFu Z2VzIGluIHYyOgo+IC0gcGF0Y2ggYWRkZWQgdG8gdGhlIHNlcmllcwo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vbXNtL2RzaS9wbGwvZHNpX3BsbF8yOG5tLmMgfCAzNiArKysrKysrKysrKysrKyst LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvcGxsL2RzaV9wbGxf MjhubS5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvcGxsL2RzaV9wbGxfMjhubS5jCj4gaW5k ZXggMjZlM2EwMWE5OWMyYi4uNzc3NzM0MGIwM2U4ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vbXNtL2RzaS9wbGwvZHNpX3BsbF8yOG5tLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v bXNtL2RzaS9wbGwvZHNpX3BsbF8yOG5tLmMKPiBAQCAtNDAsNyArNDAsNiBAQAo+ICAKPiAgI2Rl ZmluZSBOVU1fUFJPVklERURfQ0xLUwkJMgo+ICAKPiAtI2RlZmluZSBWQ09fUkVGX0NMS19SQVRF CQkxOTIwMDAwMAo+ICAjZGVmaW5lIFZDT19NSU5fUkFURQkJCTM1MDAwMDAwMAo+ICAjZGVmaW5l IFZDT19NQVhfUkFURQkJCTc1MDAwMDAwMAo+ICAKPiBAQCAtMTY2LDE3ICsxNjUsMTcgQEAgc3Rh dGljIGludCBkc2lfcGxsXzI4bm1fY2xrX3NldF9yYXRlKHN0cnVjdCBjbGtfaHcgKmh3LCB1bnNp Z25lZCBsb25nIHJhdGUsCj4gIAlwbGxfd3JpdGUoYmFzZSArIFJFR19EU0lfMjhubV9QSFlfUExM X0xQRkMxX0NGRywgMHg3MCk7Cj4gIAlwbGxfd3JpdGUoYmFzZSArIFJFR19EU0lfMjhubV9QSFlf UExMX0xQRkMyX0NGRywgMHgxNSk7Cj4gIAo+IC0JcmVtID0gcmF0ZSAlIFZDT19SRUZfQ0xLX1JB VEU7Cj4gKwlyZW0gPSByYXRlICUgcGFyZW50X3JhdGU7Cj4gIAlpZiAocmVtKSB7Cj4gIAkJcmVm Y2xrX2NmZyA9IERTSV8yOG5tX1BIWV9QTExfUkVGQ0xLX0NGR19EQkxSOwo+ICAJCWZyYWNfbl9t b2RlID0gMTsKPiAtCQlkaXZfZmJ4MTAwMCA9IHJhdGUgLyAoVkNPX1JFRl9DTEtfUkFURSAvIDUw MCk7Cj4gLQkJZ2VuX3Zjb19jbGsgPSBkaXZfZmJ4MTAwMCAqIChWQ09fUkVGX0NMS19SQVRFIC8g NTAwKTsKPiArCQlkaXZfZmJ4MTAwMCA9IHJhdGUgLyAocGFyZW50X3JhdGUgLyA1MDApOwo+ICsJ CWdlbl92Y29fY2xrID0gZGl2X2ZieDEwMDAgKiAocGFyZW50X3JhdGUgLyA1MDApOwo+ICAJfSBl bHNlIHsKPiAgCQlyZWZjbGtfY2ZnID0gMHgwOwo+ICAJCWZyYWNfbl9tb2RlID0gMDsKPiAtCQlk aXZfZmJ4MTAwMCA9IHJhdGUgLyAoVkNPX1JFRl9DTEtfUkFURSAvIDEwMDApOwo+IC0JCWdlbl92 Y29fY2xrID0gZGl2X2ZieDEwMDAgKiAoVkNPX1JFRl9DTEtfUkFURSAvIDEwMDApOwo+ICsJCWRp dl9mYngxMDAwID0gcmF0ZSAvIChwYXJlbnRfcmF0ZSAvIDEwMDApOwo+ICsJCWdlbl92Y29fY2xr ID0gZGl2X2ZieDEwMDAgKiAocGFyZW50X3JhdGUgLyAxMDAwKTsKPiAgCX0KPiAgCj4gIAlEQkco InJlZmNsa19jZmcgPSAlZCIsIHJlZmNsa19jZmcpOwo+IEBAIC0yNjUsNyArMjY0LDcgQEAgc3Rh dGljIHVuc2lnbmVkIGxvbmcgZHNpX3BsbF8yOG5tX2Nsa19yZWNhbGNfcmF0ZShzdHJ1Y3QgY2xr X2h3ICpodywKPiAgCXZvaWQgX19pb21lbSAqYmFzZSA9IHBsbF8yOG5tLT5tbWlvOwo+ICAJdTMy IHNkbTAsIGRvdWJsZXIsIHNkbV9ieXBfZGl2Owo+ICAJdTMyIHNkbV9kY19vZmYsIHNkbV9mcmVx X3NlZWQsIHNkbTIsIHNkbTM7Cj4gLQl1MzIgcmVmX2NsayA9IFZDT19SRUZfQ0xLX1JBVEU7Cj4g Kwl1MzIgcmVmX2NsayA9IHBhcmVudF9yYXRlOwo+ICAJdW5zaWduZWQgbG9uZyB2Y29fcmF0ZTsK PiAgCj4gIAlWRVJCKCJwYXJlbnRfcmF0ZT0lbHUiLCBwYXJlbnRfcmF0ZSk7Cj4gQEAgLTI3Myw3 ICsyNzIsNyBAQCBzdGF0aWMgdW5zaWduZWQgbG9uZyBkc2lfcGxsXzI4bm1fY2xrX3JlY2FsY19y YXRlKHN0cnVjdCBjbGtfaHcgKmh3LAo+ICAJLyogQ2hlY2sgdG8gc2VlIGlmIHRoZSByZWYgY2xr IGRvdWJsZXIgaXMgZW5hYmxlZCAqLwo+ICAJZG91YmxlciA9IHBsbF9yZWFkKGJhc2UgKyBSRUdf RFNJXzI4bm1fUEhZX1BMTF9SRUZDTEtfQ0ZHKSAmCj4gIAkJCURTSV8yOG5tX1BIWV9QTExfUkVG Q0xLX0NGR19EQkxSOwo+IC0JcmVmX2NsayArPSAoZG91YmxlciAqIFZDT19SRUZfQ0xLX1JBVEUp Owo+ICsJcmVmX2NsayArPSAoZG91YmxlciAqIHJlZl9jbGspOwo+ICAKPiAgCS8qIHNlZSBpZiBp dCBpcyBpbnRlZ2VyIG1vZGUgb3Igc2RtIG1vZGUgKi8KPiAgCXNkbTAgPSBwbGxfcmVhZChiYXNl ICsgUkVHX0RTSV8yOG5tX1BIWV9QTExfU0RNX0NGRzApOwo+IEBAIC01MTQsMTEgKzUxMywxMiBA QCBzdGF0aWMgdm9pZCBkc2lfcGxsXzI4bm1fZGVzdHJveShzdHJ1Y3QgbXNtX2RzaV9wbGwgKnBs bCkKPiAgCXBsbF8yOG5tLT5jbGtfZGF0YS5jbGtfbnVtID0gMDsKPiAgfQo+ICAKPiAtc3RhdGlj IGludCBwbGxfMjhubV9yZWdpc3RlcihzdHJ1Y3QgZHNpX3BsbF8yOG5tICpwbGxfMjhubSkKPiAr c3RhdGljIGludCBwbGxfMjhubV9yZWdpc3RlcihzdHJ1Y3QgZHNpX3BsbF8yOG5tICpwbGxfMjhu bSwKPiArCQkJICAgICBjb25zdCBjaGFyICpyZWZfY2xrX25hbWUpCj4gIHsKPiAgCWNoYXIgY2xr X25hbWVbMzJdLCBwYXJlbnQxWzMyXSwgcGFyZW50MlszMl0sIHZjb19uYW1lWzMyXTsKPiAgCXN0 cnVjdCBjbGtfaW5pdF9kYXRhIHZjb19pbml0ID0gewo+IC0JCS5wYXJlbnRfbmFtZXMgPSAoY29u c3QgY2hhciAqW10peyAieG8iIH0sCj4gKwkJLnBhcmVudF9uYW1lcyA9ICZyZWZfY2xrX25hbWUs Cj4gIAkJLm51bV9wYXJlbnRzID0gMSwKPiAgCQkubmFtZSA9IHZjb19uYW1lLAo+ICAJCS5mbGFn cyA9IENMS19JR05PUkVfVU5VU0VELAo+IEBAIC01OTMsNiArNTkzLDggQEAgc3RydWN0IG1zbV9k c2lfcGxsICptc21fZHNpX3BsbF8yOG5tX2luaXQoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl diwKPiAgewo+ICAJc3RydWN0IGRzaV9wbGxfMjhubSAqcGxsXzI4bm07Cj4gIAlzdHJ1Y3QgbXNt X2RzaV9wbGwgKnBsbDsKPiArCXN0cnVjdCBjbGsgKnZjb19yZWZfY2xrOwo+ICsJY29uc3QgY2hh ciAqdmNvX3JlZl9jbGtfbmFtZTsKPiAgCWludCByZXQ7Cj4gIAo+ICAJaWYgKCFwZGV2KQo+IEBA IC02MDUsNiArNjA3LDE4IEBAIHN0cnVjdCBtc21fZHNpX3BsbCAqbXNtX2RzaV9wbGxfMjhubV9p bml0KHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsCj4gIAlwbGxfMjhubS0+cGRldiA9IHBk ZXY7Cj4gIAlwbGxfMjhubS0+aWQgPSBpZDsKPiAgCj4gKwl2Y29fcmVmX2NsayA9IGRldm1fY2xr X2dldCgmcGRldi0+ZGV2LCAicmVmIik7Cj4gKwlpZiAoIUlTX0VSUih2Y29fcmVmX2NsaykpIHsK PiArCQl2Y29fcmVmX2Nsa19uYW1lID0gX19jbGtfZ2V0X25hbWUodmNvX3JlZl9jbGspOwo+ICsJ fSBlbHNlIHsKPiArCQlyZXQgPSBQVFJfRVJSKHZjb19yZWZfY2xrKTsKPiArCQlpZiAocmV0ID09 IC1FUFJPQkVfREVGRVIpCj4gKwkJCUVSUl9QVFIocmV0KTsKCkl0IGxvb2tzIGxpa2UgeW91IGFy ZSBtaXNzaW5nIHRoZSByZXR1cm4ga2V5d29yZCBoZXJlLgoKPiArCj4gKwkJZGV2X3dhcm4oJnBk ZXYtPmRldiwgIidyZWYnIGNsb2NrIGlzIG5vdCBzcGVjaWZpZWQsIHVzaW5nIGRlZmF1bHQgbmFt ZVxuIik7Cj4gKwkJdmNvX3JlZl9jbGtfbmFtZSA9ICJ4byI7Cj4gKwl9Cj4gKwo+ICAJcGxsXzI4 bm0tPm1taW8gPSBtc21faW9yZW1hcChwZGV2LCAiZHNpX3BsbCIsICJEU0lfUExMIik7Cj4gIAlp ZiAoSVNfRVJSX09SX05VTEwocGxsXzI4bm0tPm1taW8pKSB7Cj4gIAkJZGV2X2VycigmcGRldi0+ ZGV2LCAiJXM6IGZhaWxlZCB0byBtYXAgcGxsIGJhc2VcbiIsIF9fZnVuY19fKTsKPiBAQCAtNjM3 LDcgKzY1MSw3IEBAIHN0cnVjdCBtc21fZHNpX3BsbCAqbXNtX2RzaV9wbGxfMjhubV9pbml0KHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsCj4gIAkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7 Cj4gIAl9Cj4gIAo+IC0JcmV0ID0gcGxsXzI4bm1fcmVnaXN0ZXIocGxsXzI4bm0pOwo+ICsJcmV0 ID0gcGxsXzI4bm1fcmVnaXN0ZXIocGxsXzI4bm0sIHZjb19yZWZfY2xrX25hbWUpOwo+ICAJaWYg KHJldCkgewo+ICAJCWRldl9lcnIoJnBkZXYtPmRldiwgImZhaWxlZCB0byByZWdpc3RlciBQTEw6 ICVkXG4iLCByZXQpOwo+ICAJCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gLS0gCj4gMi4yMC4wLnJj MS4zODcuZ2Y4NTA1NzYyZTMtZ29vZwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9mcmVlZHJlbm8K