From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: dts: exynos: Specify I2S assigned clocks in proper node Date: Thu, 13 Dec 2018 21:56:56 +0100 Message-ID: <20181213205656.GA799@kozik-lap> References: <20181212175744.8287-1-s.nawrocki@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20181212175744.8287-1-s.nawrocki@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Sylwester Nawrocki Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Dec 12, 2018 at 06:57:44PM +0100, Sylwester Nawrocki wrote: > The assigned parent clocks should be normally specified in the consumer > device's DT node, this ensures respective driver always sees correct clock > settings when required. > > This patch fixes regression in audio subsystem on Odroid XU3/XU4 boards > that appeared after commits: > > 'commit 647d04f8e07a ("ASoC: samsung: i2s: Ensure the RCLK rate is properly determined")' > 'commit 995e73e55f46 ("ASoC: samsung: i2s: Fix rclk_srcrate handling")' > 'commit 48279c53fd1d ("ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access")' > > Without this patch the driver gets wrong clock as the I2S function (op_clk) > clock in probe() and effectively the clock which is finally assigned from DT > is not being enabled/disabled in the runtime resume/suspend ops. > > Without the above listed commits the EXYNOS_I2S_BUS clock was always set > as parent of CLK_I2S_RCLK_SRC regardless of DT settings so there was no issue > with not enabled EXYNOS_SCLK_I2S. > > Cc: stable@vger.kernel.org # v4.17+ I gues your format would work (got recognized by stable scripts) but strictly speaking format is different: Cc: # 4.17.x https://elixir.bootlin.com/linux/latest/source/Documentation/process/stable-kernel-rules.rst#L127 Thanks, fixed and applied. Best regards, Krzysztof