From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kamil Konieczny <k.konieczny@partner.samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
devicetree@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3 4/5] arm64: dts: exynos: add imem clock
Date: Thu, 13 Dec 2018 22:10:09 +0100 [thread overview]
Message-ID: <20181213211009.GA5444@kozik-lap> (raw)
In-Reply-To: <20181204165248.17572-5-k.konieczny@partner.samsung.com>
On Tue, Dec 04, 2018 at 05:52:47PM +0100, Kamil Konieczny wrote:
> Add description for imem clock in the Samsung Exynos5433. The users can use
> compatibility "samsung,exynos5433-cmu-imem".
Thanks, applied but the commit message above is not matching contents at all.
You did not add the description. Mentioning some users and compatibility
also seems unrelated. Instead:
1. You added DT node for IMEM clock controller on Exynos5433.
2. Because it is necessary for SSS to work (beside obvious reasons: for
DTS completeness and allowing to gate them when not used).
Also, please use SoC name in commit title (for example at the end) to
differentiate from Exynos7 or any other future SoCs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2018-12-13 21:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181204165315eucas1p1693a3d349f39c272297e5d1902c905ca@eucas1p1.samsung.com>
2018-12-04 16:52 ` [PATCH v3 0/5] Add imem clock for Exynos 5433 Kamil Konieczny
[not found] ` <CGME20181204165316eucas1p2da523b358ed62eca270fe24c5e2b063c@eucas1p2.samsung.com>
2018-12-04 16:52 ` [PATCH v3 1/5] clk: samsung: exynos5433: fix typo in imem divider Kamil Konieczny
[not found] ` <CGME20181204165316eucas1p2ba063b96e83d2d2be93ca067d32d7926@eucas1p2.samsung.com>
2018-12-04 16:52 ` [PATCH v3 2/5] clk: samsung: exynos5433: fix name typo in sssx Kamil Konieczny
2018-12-10 22:29 ` Rob Herring
[not found] ` <CGME20181204165317eucas1p10bef0207ee57a9420911410ed2a22453@eucas1p1.samsung.com>
2018-12-04 16:52 ` [PATCH v3 3/5] dt-bindings: clk: exynos5433: document imem clock Kamil Konieczny
2018-12-04 18:41 ` Stephen Boyd
2018-12-10 22:32 ` Rob Herring
2018-12-11 5:06 ` Chanwoo Choi
[not found] ` <CGME20181204165317eucas1p18cd6168fdefb2aa57259b9ec73438275@eucas1p1.samsung.com>
2018-12-04 16:52 ` [PATCH v3 4/5] arm64: dts: exynos: add " Kamil Konieczny
2018-12-13 21:10 ` Krzysztof Kozlowski [this message]
2019-01-21 8:08 ` Kamil Konieczny
[not found] ` <CGME20181204165318eucas1p2dccd5382ee8b9f4da8c3076fb56607ee@eucas1p2.samsung.com>
2018-12-04 16:52 ` [PATCH v3 5/5] clk: samsung: exynos5433: add imem clocks Kamil Konieczny
2018-12-04 18:40 ` Stephen Boyd
2018-12-05 10:57 ` Sylwester Nawrocki
2018-12-05 16:08 ` Stephen Boyd
2018-12-05 17:25 ` Sylwester Nawrocki
2018-12-10 22:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213211009.GA5444@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.konieczny@partner.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).