From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Date: Thu, 13 Dec 2018 20:52:18 -0800 Message-ID: <20181214045218.GJ1578@tuxbook-pro> References: <20181127085828.17908-1-sibis@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: sibis@codeaurora.org, Rob Herring , Andy Gross , David Brown , linux-arm-msm , "open list:ARM/QUALCOMM SUPPORT" , devicetree@vger.kernel.org, LKML , tsoni@codeaurora.org, clew@codeaurora.org, akdwived@codeaurora.org, Mark Rutland , linux-remoteproc@vger.kernel.org, Evan Green , Brian Norris List-Id: devicetree@vger.kernel.org On Thu 13 Dec 14:17 PST 2018, Doug Anderson wrote: > On Tue, Nov 27, 2018 at 12:58 AM Sibi Sankar wrote: [..] > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > index 58870273dbc9..df16ee464872 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > @@ -1095,6 +1095,69 @@ > > }; > > }; > > > > + remoteproc@4080000 { > > + compatible = "qcom,sdm845-mss-pil"; > > + reg = <0x04080000 0x408>, <0x04180000 0x48>; > > s/0x04080000/0x4080000 to appease the DT folks. > Andy requests this to be padded to 8 digits, and I've come to really appreciate this as it makes sorting much easier. But perhaps there's a verdict on this? Regards, Bjorn