From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f194.google.com ([209.85.210.194]:44114 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbeLOR5C (ORCPT ); Sat, 15 Dec 2018 12:57:02 -0500 Received: by mail-pf1-f194.google.com with SMTP id u6so4351615pfh.11 for ; Sat, 15 Dec 2018 09:57:01 -0800 (PST) Date: Sat, 15 Dec 2018 09:56:57 -0800 From: Bjorn Andersson Subject: Re: [PATCH v3 4/7] clk: qcom: Add WCSS gcc clock control for QCS404 Message-ID: <20181215175657.GB12886@minitux> References: <20181215103557.2748-1-govinds@codeaurora.org> <20181215103557.2748-5-govinds@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181215103557.2748-5-govinds@codeaurora.org> Sender: devicetree-owner@vger.kernel.org To: Govind Singh Cc: linux-remoteproc@vger.kernel.org, sboyd@kernel.org, linux-clk@vger.kernel.org, sricharan@codeaurora.org, sibis@codeaurora.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, david.brown@linaro.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org List-ID: On Sat 15 Dec 02:35 PST 2018, Govind Singh wrote: > diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c [..] > @@ -2726,6 +2770,11 @@ static int gcc_qcs404_probe(struct platform_device *pdev) > return ret; > } > > +#ifdef CONFIG_QCS_WCSSCC_404 We don't do compile time configuration of things like this, expect all variants of QCS404 (regardless of security solution) to run off the same kernel binary. Instead use the recently introduced "protected-clocks" property. Regards, Bjorn