From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: David Lechner <david@lechnology.com>,
Roger Quadros <rogerq@ti.com>,
ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org,
bcousson@baylibre.com, ssantosh@kernel.org, s-anna@ti.com,
nsekhar@ti.com, t-kristo@ti.com, nsaulnier@ti.com,
jreeder@ti.com, m-karicheri2@ti.com, woods.technical@gmail.com,
linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support
Date: Wed, 19 Dec 2018 09:18:16 -0800 [thread overview]
Message-ID: <20181219171816.GE6707@atomide.com> (raw)
In-Reply-To: <20181219170725.GH8130@sirena.org.uk>
* Mark Brown <broonie@kernel.org> [181219 17:07]:
> On Wed, Dec 19, 2018 at 04:48:52PM +0100, David Lechner wrote:
> > On 12/19/18 4:43 PM, Roger Quadros wrote:
>
> > > Did I do something wrong or we just need to enhance regmap_debugfs.c?
>
> > Do you assign the name field in pru_regmap_config and
> > pru_debug_regmap_config?
>
> Yeah, you'll at least need to override the name since the default is to
> use the name of the device and that'll result in two duplicates.
Also combining IO regions often has a serious issue that the
separate IO regions may not be in the same device (or same
interconnect target module).
This means that flushing a posted write with a read-back for
an IO region will only flush it for a single device and not
the other(s). And this leads into hard to find bugs :)
Regards,
Tony
next prev parent reply other threads:[~2018-12-19 17:18 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 7:52 [PATCH 00/16] remoteproc: Add support for TI PRU Roger Quadros
2018-11-26 7:52 ` [PATCH 01/16] remoteproc: Extend rproc_da_to_va() API with a flags parameter Roger Quadros
2018-11-26 21:29 ` David Lechner
2018-11-29 10:29 ` Roger Quadros
2018-11-29 16:12 ` David Lechner
2018-12-04 10:03 ` Roger Quadros
2019-02-14 3:35 ` Suman Anna
2018-11-26 7:52 ` [PATCH 02/16] remoteproc: Add a rproc_set_firmware() API Roger Quadros
2018-11-26 21:41 ` David Lechner
2018-11-29 8:51 ` Roger Quadros
2018-11-26 7:52 ` [PATCH 03/16] remoteproc: Add support to handle device specific resource types Roger Quadros
2018-11-26 7:52 ` [PATCH 04/16] remoteproc/pru: Add PRU remoteproc driver Roger Quadros
2018-11-26 22:32 ` David Lechner
2018-11-29 9:26 ` Roger Quadros
2018-11-30 21:39 ` Dimitar Dimitrov
2018-12-04 8:47 ` Roger Quadros
2018-12-14 9:53 ` Roger Quadros
2018-12-15 13:43 ` Dimitar Dimitrov
2018-11-26 7:52 ` [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support Roger Quadros
2018-11-26 22:37 ` David Lechner
2018-11-29 10:17 ` Roger Quadros
2018-12-18 15:51 ` Roger Quadros
2018-12-19 12:38 ` Mark Brown
2018-12-19 15:43 ` Roger Quadros
2018-12-19 15:48 ` David Lechner
2018-12-19 17:07 ` Mark Brown
2018-12-19 17:18 ` Tony Lindgren [this message]
2018-12-20 8:45 ` Roger Quadros
2018-11-26 7:52 ` [PATCH 06/16] dt-bindings: remoteproc: ti-pruss: Update bindings for supporting rpmsg Roger Quadros
2018-11-26 7:52 ` [PATCH 07/16] remoteproc/pru: Add support for virtio rpmsg stack Roger Quadros
2018-11-26 7:52 ` [PATCH 08/16] remoteproc/pru: Add pru_rproc_set_ctable() function Roger Quadros
2018-11-26 7:52 ` [PATCH 09/16] remoteproc/pru: add APIs to get and put the PRU cores Roger Quadros
2018-11-26 7:52 ` [PATCH 10/16] remoteproc/pru: add pru_rproc_get_id() API to retrieve the PRU id Roger Quadros
2018-11-26 7:52 ` [PATCH 11/16] soc: ti: pruss: add helper functions to set GPI mode, MII_RT_event and XFR Roger Quadros
2018-11-26 7:52 ` [PATCH 12/16] dt-bindings: remoteproc: ti-pruss: Document application node bindings Roger Quadros
2018-11-26 23:27 ` David Lechner
2018-11-29 10:07 ` Roger Quadros
2018-11-29 16:33 ` David Lechner
2018-11-30 11:42 ` Roger Quadros
2018-12-11 22:06 ` Rob Herring
2018-12-17 16:03 ` Roger Quadros
2018-11-26 7:52 ` [PATCH 13/16] remoteproc/pru: add support for configuring GPMUX based on client setup Roger Quadros
2018-11-26 7:52 ` [PATCH 14/16] remoteproc/pru: configure firmware " Roger Quadros
2018-11-26 7:52 ` [PATCH 15/16] remoteproc/pru: add support for parsing pru interrupt mapping from DT Roger Quadros
2018-11-26 7:52 ` [PATCH 16/16] remoteproc/pru: Add support for INTC Interrupt map resource Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219171816.GE6707@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=jreeder@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsaulnier@ti.com \
--cc=nsekhar@ti.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=woods.technical@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).