From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v2 2/4] video: ssd1307fb: Do not hard code active-low reset sequence Date: Thu, 20 Dec 2018 13:33:59 +0100 Message-ID: <20181220123359.GF2188@piout.net> References: <1545308005-51559-1-git-send-email-michal.vokac@ysoft.com> <1545308005-51559-3-git-send-email-michal.vokac@ysoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1545308005-51559-3-git-send-email-michal.vokac@ysoft.com> Sender: linux-kernel-owner@vger.kernel.org To: =?utf-8?B?Vm9rw6HEjQ==?= Michal Cc: Rob Herring , Bartlomiej Zolnierkiewicz , Shawn Guo , Fabio Estevam , Maxime Ripard , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 20/12/2018 12:13:55+0000, Vokáč Michal wrote: > The SSD130x OLED display reset signal is active low. Now the reset > sequence is implemented in such a way that users are forced to > define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work. > > Do not hard code the active-low sequence into the driver but instead > allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect > the real world. > > Reviewed-by: Rob Herring > Signed-off-by: Michal Vokáč Reviewed-by: Alexandre Belloni > --- > Changes from v1: > - Add R-by from Rob > > drivers/video/fbdev/ssd1307fb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index 4061a20..3b361bc 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -667,10 +667,10 @@ static int ssd1307fb_probe(struct i2c_client *client, > > if (par->reset) { > /* Reset the screen */ > - gpiod_set_value_cansleep(par->reset, 0); > - udelay(4); > gpiod_set_value_cansleep(par->reset, 1); > udelay(4); > + gpiod_set_value_cansleep(par->reset, 0); > + udelay(4); > } > > if (par->vbat_reg) { > -- > 2.1.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com