* [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig
@ 2018-12-20 16:17 Johan Hovold
2019-02-11 9:37 ` Johan Hovold
2019-02-12 21:06 ` Andy Gross
0 siblings, 2 replies; 5+ messages in thread
From: Johan Hovold @ 2018-12-20 16:17 UTC (permalink / raw)
To: Andy Gross
Cc: David Brown, linux-arm-msm, devicetree, linux-kernel,
Johan Hovold, Srinivas Kandagatla
Fix "gpiio5" typo in the (currently unused) blsp2_uart1 4-pin sleep
config.
Fixes: 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
index c5c42e94f387..1d1f7f91739a 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
@@ -139,7 +139,7 @@
};
pinconf {
- pins = "gpio4", "gpiio5", "gpio6", "gpio7";
+ pins = "gpio4", "gpio5", "gpio6", "gpio7";
drive-strength = <2>;
bias-disable;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig
2018-12-20 16:17 [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig Johan Hovold
@ 2019-02-11 9:37 ` Johan Hovold
2019-02-12 21:06 ` Andy Gross
1 sibling, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2019-02-11 9:37 UTC (permalink / raw)
To: Andy Gross
Cc: David Brown, linux-arm-msm, devicetree, linux-kernel,
Johan Hovold, Srinivas Kandagatla
On Thu, Dec 20, 2018 at 05:17:50PM +0100, Johan Hovold wrote:
> Fix "gpiio5" typo in the (currently unused) blsp2_uart1 4-pin sleep
> config.
>
> Fixes: 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
I can't seem to find this one in your tree (or linux-next), Andy. Lost
or simply not applied yet?
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig
2018-12-20 16:17 [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig Johan Hovold
2019-02-11 9:37 ` Johan Hovold
@ 2019-02-12 21:06 ` Andy Gross
2019-02-13 9:05 ` Johan Hovold
1 sibling, 1 reply; 5+ messages in thread
From: Andy Gross @ 2019-02-12 21:06 UTC (permalink / raw)
To: Johan Hovold
Cc: David Brown, linux-arm-msm, devicetree, linux-kernel,
Srinivas Kandagatla
On Thu, Dec 20, 2018 at 05:17:50PM +0100, Johan Hovold wrote:
> Fix "gpiio5" typo in the (currently unused) blsp2_uart1 4-pin sleep
> config.
>
> Fixes: 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> index c5c42e94f387..1d1f7f91739a 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> @@ -139,7 +139,7 @@
> };
>
> pinconf {
> - pins = "gpio4", "gpiio5", "gpio6", "gpio7";
> + pins = "gpio4", "gpio5", "gpio6", "gpio7";
> drive-strength = <2>;
> bias-disable;
> };
I took one in slightly older than this one. However, it doesn't have the fixes
line.
commit ff10032fb309d0baa0b79e28009bf154de08d341
Author: Jakob Wuhrer <jakobwuhrer@airmail.cc>
Date: Fri Dec 14 18:01:30 2018 +0100
arm64: dts: qcom: Correct "gpiio" typo in msm8996-pins
gpiio5 is missspelt in msm8996-pins.dtsi, fix that.
Signed-off-by: Jakob Wuhrer <jakobwuhrer@airmail.cc>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
Regards,
Andy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig
2019-02-12 21:06 ` Andy Gross
@ 2019-02-13 9:05 ` Johan Hovold
2019-02-14 16:14 ` Andy Gross
0 siblings, 1 reply; 5+ messages in thread
From: Johan Hovold @ 2019-02-13 9:05 UTC (permalink / raw)
To: Andy Gross
Cc: Johan Hovold, David Brown, linux-arm-msm, devicetree,
linux-kernel, Srinivas Kandagatla
On Tue, Feb 12, 2019 at 03:06:56PM -0600, Andy Gross wrote:
> On Thu, Dec 20, 2018 at 05:17:50PM +0100, Johan Hovold wrote:
> > Fix "gpiio5" typo in the (currently unused) blsp2_uart1 4-pin sleep
> > config.
> >
> > Fixes: 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> > index c5c42e94f387..1d1f7f91739a 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996-pins.dtsi
> > @@ -139,7 +139,7 @@
> > };
> >
> > pinconf {
> > - pins = "gpio4", "gpiio5", "gpio6", "gpio7";
> > + pins = "gpio4", "gpio5", "gpio6", "gpio7";
> > drive-strength = <2>;
> > bias-disable;
> > };
>
> I took one in slightly older than this one. However, it doesn't have the fixes
> line.
>
>
> commit ff10032fb309d0baa0b79e28009bf154de08d341
> Author: Jakob Wuhrer <jakobwuhrer@airmail.cc>
> Date: Fri Dec 14 18:01:30 2018 +0100
>
> arm64: dts: qcom: Correct "gpiio" typo in msm8996-pins
>
> gpiio5 is missspelt in msm8996-pins.dtsi, fix that.
>
> Signed-off-by: Jakob Wuhrer <jakobwuhrer@airmail.cc>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
That's funny, submitted six days before mine for a 2+ year old issue.
The typo would prevent the pin from being reconfigured (hence the stable
tag), but at least you'd get a runtime warning when trying to set this
config.
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-14 16:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-20 16:17 [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig Johan Hovold
2019-02-11 9:37 ` Johan Hovold
2019-02-12 21:06 ` Andy Gross
2019-02-13 9:05 ` Johan Hovold
2019-02-14 16:14 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).