* [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding
[not found] <20181217153706.25873-1-marek.behun@nic.cz>
@ 2018-12-17 15:37 ` Marek Behún
2018-12-20 21:44 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Marek Behún @ 2018-12-17 15:37 UTC (permalink / raw)
To: Jassi Brar
Cc: linux-kernel, Gregory CLEMENT, linux-arm-kernel, Marek Behún,
Rob Herring, devicetree
This adds device tree binding documentation for the rWTM BIU mailbox
driver on the Armada 37xx SOC (EspressoBin, Turris Mox).
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
---
.../mailbox/armada-37xx-rwtm-mailbox.txt | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
diff --git a/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
new file mode 100644
index 000000000000..2d182d61eb3f
--- /dev/null
+++ b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
@@ -0,0 +1,16 @@
+* rWTM BIU Mailbox driver for Armada 37xx
+
+Required properties:
+- compatible : must be "marvell,armada-37xx-rwtm-mailbox"
+- reg : physical base address of the mailbox and length of memory mapped
+ region
+- interrupts: the IRQ line for the mailbox
+- #mbox-cells: must be 1
+
+Example:
+ rwtm: mailbox@b0000 {
+ compatible = "marvell,armada-37xx-rwtm-mailbox";
+ reg = <0xb0000 0x100>;
+ interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
+ #mbox-cells = <1>;
+ };
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding
2018-12-17 15:37 ` [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding Marek Behún
@ 2018-12-20 21:44 ` Rob Herring
2018-12-20 22:08 ` Marek Behun
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2018-12-20 21:44 UTC (permalink / raw)
To: Marek Behún
Cc: Jassi Brar, linux-kernel, Gregory CLEMENT, linux-arm-kernel,
devicetree
On Mon, Dec 17, 2018 at 04:37:05PM +0100, Marek Behún wrote:
> This adds device tree binding documentation for the rWTM BIU mailbox
> driver on the Armada 37xx SOC (EspressoBin, Turris Mox).
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../mailbox/armada-37xx-rwtm-mailbox.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
>
> diff --git a/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> new file mode 100644
> index 000000000000..2d182d61eb3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/armada-37xx-rwtm-mailbox.txt
> @@ -0,0 +1,16 @@
> +* rWTM BIU Mailbox driver for Armada 37xx
> +
> +Required properties:
> +- compatible : must be "marvell,armada-37xx-rwtm-mailbox"
Don't use wildcards in compatible strings.
> +- reg : physical base address of the mailbox and length of memory mapped
mixed space and tab.
> + region
> +- interrupts: the IRQ line for the mailbox
> +- #mbox-cells: must be 1
> +
> +Example:
> + rwtm: mailbox@b0000 {
> + compatible = "marvell,armada-37xx-rwtm-mailbox";
> + reg = <0xb0000 0x100>;
> + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> + #mbox-cells = <1>;
> + };
> --
> 2.18.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding
2018-12-20 21:44 ` Rob Herring
@ 2018-12-20 22:08 ` Marek Behun
2018-12-21 5:13 ` Baruch Siach
0 siblings, 1 reply; 4+ messages in thread
From: Marek Behun @ 2018-12-20 22:08 UTC (permalink / raw)
To: Rob Herring
Cc: Jassi Brar, linux-kernel, Gregory CLEMENT, linux-arm-kernel,
devicetree
> > +- compatible : must be "marvell,armada-37xx-rwtm-mailbox"
>
> Don't use wildcards in compatible strings.
>
You mean that "mailbox" shouldn't be there?
Marek
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding
2018-12-20 22:08 ` Marek Behun
@ 2018-12-21 5:13 ` Baruch Siach
0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2018-12-21 5:13 UTC (permalink / raw)
To: Marek Behun
Cc: Rob Herring, devicetree, Gregory CLEMENT, Jassi Brar,
linux-kernel, linux-arm-kernel
Hi Marek,
Marek Behun writes:
>> > +- compatible : must be "marvell,armada-37xx-rwtm-mailbox"
>>
>> Don't use wildcards in compatible strings.
>
> You mean that "mailbox" shouldn't be there?
You should use '3700' instead of '37xx'.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-21 5:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181217153706.25873-1-marek.behun@nic.cz>
2018-12-17 15:37 ` [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding Marek Behún
2018-12-20 21:44 ` Rob Herring
2018-12-20 22:08 ` Marek Behun
2018-12-21 5:13 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).