devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Olliver Schinagl <oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH v2 1/8] mfd: axp20x: name voltage ramping define properly
Date: Fri, 21 Dec 2018 08:39:27 +0000	[thread overview]
Message-ID: <20181221083927.GQ4497@dell> (raw)
In-Reply-To: <01367c4f4f1e174fefbef9aac645f6792bda07e5.1544512919.git-series.plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>

On Tue, 11 Dec 2018, Priit Laes wrote:

> From: Olliver Schinagl <oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
> 
> The current axp20x names the ramping register 'scal' which probably
> means scaling. Since the register really has nothing to do with
> scaling, but really is the voltage ramp we rename it appropriately.
> 
> Signed-off-by: Olliver Schinagl <oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
> Signed-off-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
> Acked-for-MFD-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  include/linux/mfd/axp20x.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I've lost track of what's happening with this set now.

Mark,

Did you take this patch in the end?

> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index 2302b62..a353cd2 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -35,7 +35,7 @@ enum axp20x_variants {
>  #define AXP152_ALDO_OP_MODE		0x13
>  #define AXP152_LDO0_CTRL		0x15
>  #define AXP152_DCDC2_V_OUT		0x23
> -#define AXP152_DCDC2_V_SCAL		0x25
> +#define AXP152_DCDC2_V_RAMP		0x25
>  #define AXP152_DCDC1_V_OUT		0x26
>  #define AXP152_DCDC3_V_OUT		0x27
>  #define AXP152_ALDO12_V_OUT		0x28
> @@ -53,7 +53,7 @@ enum axp20x_variants {
>  #define AXP20X_USB_OTG_STATUS		0x02
>  #define AXP20X_PWR_OUT_CTRL		0x12
>  #define AXP20X_DCDC2_V_OUT		0x23
> -#define AXP20X_DCDC2_LDO3_V_SCAL	0x25
> +#define AXP20X_DCDC2_LDO3_V_RAMP	0x25
>  #define AXP20X_DCDC3_V_OUT		0x27
>  #define AXP20X_LDO24_V_OUT		0x28
>  #define AXP20X_LDO3_V_OUT		0x29

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2018-12-21  8:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 15:17 [PATCH v2 0/8] regulator: axp20x: Stop AXP209 from crashing when enabling LDO3 Priit Laes
     [not found] ` <cover.923997dd7d7396bb4d71f8967698b58ca956b929.1544512919.git-series.plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2018-12-11 15:17   ` [PATCH v2 1/8] mfd: axp20x: name voltage ramping define properly Priit Laes
     [not found]     ` <01367c4f4f1e174fefbef9aac645f6792bda07e5.1544512919.git-series.plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2018-12-21  8:39       ` Lee Jones [this message]
2018-12-21  8:42         ` [linux-sunxi] " Priit Laes
2018-12-21  9:26           ` Lee Jones
2018-12-21  9:28             ` Priit Laes
     [not found]               ` <20181221092858.6koh5dkrlc7xhvbh-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2018-12-21  9:57                 ` Lee Jones
2018-12-11 15:17   ` [PATCH v2 2/8] regulator: axp20x: add support for set_ramp_delay for AXP209 Priit Laes
2018-12-11 15:17   ` [PATCH v2 7/8] mfd: axp20x: Clean up included headers Priit Laes
2018-12-11 15:17   ` [PATCH v2 8/8] mfd: axp20x: use explicit bit defines Priit Laes
2018-12-11 15:17 ` [PATCH v2 3/8] dt-bindings: mfd: axp20x: add support for regulator-ramp-delay for AXP209 Priit Laes
2018-12-11 15:17 ` [PATCH v2 4/8] regulator: axp20x: add software based soft_start for AXP209 LDO3 Priit Laes
2018-12-11 15:17 ` [PATCH v2 5/8] dt-bindings: mfd: axp20x: Add " Priit Laes
     [not found]   ` <25e67fe9b5397aa5f11bdd7026e4ae6be51dd18b.1544512919.git-series.plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2018-12-21  8:40     ` Lee Jones
2018-12-11 15:17 ` [PATCH v2 6/8] regulator: dts: enable soft-start and ramp delay for the OLinuXino Lime2 Priit Laes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181221083927.GQ4497@dell \
    --to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
    --cc=oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org \
    --cc=plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).