From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: Add wlcore wakeirq for omap3-evm
Date: Sun, 23 Dec 2018 08:30:40 -0800 [thread overview]
Message-ID: <20181223163040.GO6707@atomide.com> (raw)
In-Reply-To: <CAHCN7xJmde1RJOMMqexR0uNiVEYjztTV4qXvkcjqb+w7R1vmpA@mail.gmail.com>
* Adam Ford <aford173@gmail.com> [181222 20:54]:
> I noticed for your patch, I noticed you listed both the IRQ, gpio 149
> as well as uart1_rts. Looking at the device tree, I see that
> uart1_rts is configured as gpio 149.
The uart1_rts is just the pad name used in the TRM, so it should
probably say uart1_rts.gpio_149 meaning pad uart1_rts is muxed to
gpio_149.
Would that clear the issue for you?
> I did a quick scan of other
> boards, I haven't noticed other boards listing the same gpio twice,
> once under IRQ and once under the pmx_core wakeup. Is that something
> we should do on other boards, or is that something unique to the
> omap3-evm?
No just trying to come up with some some less confusing comments,
but obviously that did not work so far :)
Regards,
Tony
next prev parent reply other threads:[~2018-12-23 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 23:04 [PATCH 1/3] ARM: dts: Add wlcore wakeirq for omap3-evm Tony Lindgren
2018-12-13 23:04 ` [PATCH 2/3] ARM: dts: Configure wlcore wakeirq for pandaboard Tony Lindgren
2018-12-13 23:04 ` [PATCH 3/3] ARM: dts: omap4-droid4: Configure wlcore wakeirq Tony Lindgren
2018-12-13 23:22 ` Sebastian Reichel
2018-12-13 23:26 ` Tony Lindgren
2018-12-22 20:53 ` [PATCH 1/3] ARM: dts: Add wlcore wakeirq for omap3-evm Adam Ford
2018-12-23 16:30 ` Tony Lindgren [this message]
2018-12-27 14:33 ` Adam Ford
2018-12-27 16:58 ` Tony Lindgren
2018-12-27 17:05 ` Adam Ford
2018-12-28 20:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223163040.GO6707@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).