From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: Add wlcore wakeirq for omap3-evm
Date: Thu, 27 Dec 2018 08:58:12 -0800 [thread overview]
Message-ID: <20181227165812.GS6707@atomide.com> (raw)
In-Reply-To: <CAHCN7xJKyjXb6br-f+_q_dQxkqWHFxFfA+X_yYG4eh8w7RW8SQ@mail.gmail.com>
* Adam Ford <aford173@gmail.com> [181227 14:33]:
> On Sun, Dec 23, 2018 at 10:30 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Adam Ford <aford173@gmail.com> [181222 20:54]:
> > > I noticed for your patch, I noticed you listed both the IRQ, gpio 149
> > > as well as uart1_rts. Looking at the device tree, I see that
> > > uart1_rts is configured as gpio 149.
> >
> > The uart1_rts is just the pad name used in the TRM, so it should
> > probably say uart1_rts.gpio_149 meaning pad uart1_rts is muxed to
> > gpio_149.
> >
> > Would that clear the issue for you?
>
> That part I understand. I poorly phrased my question. What was
> mostly confusing to me is why both irq and wakeup interrupts are
> needed since it seems like
>
> <&gpio5 21 IRQ_TYPE_EDGE_RISING>,
>
> and
> <&omap3_pmx_core 0x14e>;
> point to the same pin. Or did I mis-interpret the datasheet again? :-)
Ah OK. Yes the same pin can trigger interrupts at two different
controllers. During runtime a proper GPIO is triggered, and then
in deeper idle states only the padconf interrupt is triggered as
the GPIO can be powered off. So the padconf interrupt is there
to provide wake-up events if configured. This allows the device
to enter off-mode during idle with things like ping and ssh
working with some extra latency :)
The padconf interrupt can also be something other than a GPIO pin,
such as UART RX pin, and the padconf device is separate from the
GPIO device. So they're treated as two separate interrupt
controllers. They can be both active the same time although that
is undesired for the extra overhead.
Eventually we should be able to make the GPIO interrupts work
in a transparent way with the padconf interrupts.
Regards,
Tony
next prev parent reply other threads:[~2018-12-27 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 23:04 [PATCH 1/3] ARM: dts: Add wlcore wakeirq for omap3-evm Tony Lindgren
2018-12-13 23:04 ` [PATCH 2/3] ARM: dts: Configure wlcore wakeirq for pandaboard Tony Lindgren
2018-12-13 23:04 ` [PATCH 3/3] ARM: dts: omap4-droid4: Configure wlcore wakeirq Tony Lindgren
2018-12-13 23:22 ` Sebastian Reichel
2018-12-13 23:26 ` Tony Lindgren
2018-12-22 20:53 ` [PATCH 1/3] ARM: dts: Add wlcore wakeirq for omap3-evm Adam Ford
2018-12-23 16:30 ` Tony Lindgren
2018-12-27 14:33 ` Adam Ford
2018-12-27 16:58 ` Tony Lindgren [this message]
2018-12-27 17:05 ` Adam Ford
2018-12-28 20:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227165812.GS6707@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).