From: Rob Herring <robh@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Olivier Sobrie <olivier@sobrie.be>,
Philipp Puschmann <pp@emlix.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH V2 01/10] input: touchscreen: ili210x: Add DT binding document
Date: Thu, 27 Dec 2018 15:41:46 -0600 [thread overview]
Message-ID: <20181227214146.GA13210@bogus> (raw)
In-Reply-To: <20181220204305.28807-2-marex@denx.de>
On Thu, Dec 20, 2018 at 09:42:56PM +0100, Marek Vasut wrote:
> Add DT binding document for the Ilitek ILI210x and ILI251x
> touchscreen controllers.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Olivier Sobrie <olivier@sobrie.be>
> Cc: Philipp Puschmann <pp@emlix.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> To: linux-input@vger.kernel.org
> ---
> V2: New patch
> ---
> .../bindings/input/ilitek,ili2xxx.txt | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/ilitek,ili2xxx.txt
>
> diff --git a/Documentation/devicetree/bindings/input/ilitek,ili2xxx.txt b/Documentation/devicetree/bindings/input/ilitek,ili2xxx.txt
> new file mode 100644
> index 000000000000..bc256557ae8c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/ilitek,ili2xxx.txt
> @@ -0,0 +1,25 @@
> +Ilitek ILI210x/ILI251x touchscreen controller
> +
> +Required properties:
> +- compatible:
> + ilitek,ili210x for ILI210x
> + ilitek,ili251x for ILI251x
Generally, we don't have wildcards in compatible strings. What's the 'x'
signify? I couldn't find much info on these parts.
> +
> +- reg: The I2C address of the device
> +
> +- interrupts: The sink for the touchscreen's IRQ output
> + See ../interrupt-controller/interrupts.txt
> +
> +Optional properties for main touchpad device:
> +
> +- reset-gpios: GPIO specifier for the touchscreen's reset pin (active low)
> +
> +Example:
> +
> + touch@41 {
touchscreen@41
> + compatible = "ilitek,ili251x";
> + reg = <0x41>;
> + interrupt-parent = <&gpio4>;
> + interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> + reset-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>;
> + };
> --
> 2.19.2
>
next prev parent reply other threads:[~2018-12-27 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181220204305.28807-1-marex@denx.de>
2018-12-20 20:42 ` [PATCH V2 01/10] input: touchscreen: ili210x: Add DT binding document Marek Vasut
2018-12-27 21:41 ` Rob Herring [this message]
2018-12-30 16:01 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227214146.GA13210@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=marex@denx.de \
--cc=olivier@sobrie.be \
--cc=pp@emlix.com \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).