devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: richard.leitner@skidata.com, fancer.lancer@gmail.com,
	kernel@pengutronix.de, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: usb251xb: add documentation for data lane swapping
Date: Fri, 28 Dec 2018 17:45:25 -0600	[thread overview]
Message-ID: <20181228234525.GA30428@bogus> (raw)
In-Reply-To: <20181219145941.5173-1-m.felsch@pengutronix.de>

On Wed, Dec 19, 2018 at 03:59:40PM +0100, Marco Felsch wrote:
> Add optional binding to allow USB differential-pair (D+/D-) data lane
> swapping. The swapping can be specified for each port separately,
> default is no swapping.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/usb/usb251xb.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt
> index 168ff819e827..aec93a92870d 100644
> --- a/Documentation/devicetree/bindings/usb/usb251xb.txt
> +++ b/Documentation/devicetree/bindings/usb/usb251xb.txt
> @@ -64,6 +64,8 @@ Optional properties :
>   - power-on-time-ms : Specifies the time it takes from the time the host
>  	initiates the power-on sequence to a port until the port has adequate
>  	power. The value is given in ms in a 0 - 510 range (default is 100ms).
> + - sw-dx-lanes-ports : Specifies the ports which will swap the differential-pair
> +	(D+/D-), default is not-swapped.

Perhaps 'swap-dx-ports' would be a more obvious name.

>  
>  Examples:
>  	usb2512b@2c {
> @@ -81,4 +83,6 @@ Examples:
>  		manufacturer = "Foo";
>  		product = "Foo-Bar";
>  		serial = "1234567890A";
> +		/* correct misplaced usb connectors on port 1,2 */
> +		sw-dx-lanes-ports = <1 2>;
>  	};
> -- 
> 2.19.1
> 

  parent reply	other threads:[~2018-12-28 23:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 14:59 [PATCH 1/2] dt-bindings: usb: usb251xb: add documentation for data lane swapping Marco Felsch
2018-12-19 14:59 ` [PATCH 2/2] usb: usb251xb: add usb data lane port swap feature Marco Felsch
2018-12-28 23:45 ` Rob Herring [this message]
2018-12-31 11:05   ` [PATCH 1/2] dt-bindings: usb: usb251xb: add documentation for data lane swapping Marco Felsch
2019-01-02  5:44     ` Richard Leitner
2019-01-03 13:58       ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181228234525.GA30428@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=richard.leitner@skidata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).