From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes Date: Thu, 3 Jan 2019 15:42:49 -0800 Message-ID: <20190103234249.GH31596@builder> References: <1545313174-13481-1-git-send-email-rohitkr@codeaurora.org> <1545313174-13481-2-git-send-email-rohitkr@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1545313174-13481-2-git-send-email-rohitkr@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Rohit kumar Cc: dianders@chromium.org, andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, srinivas.kandagatla@linaro.org, linux-remoteproc@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote: > Add memory nodes required for remoteproc q6v5_adsp pil. > This range doesn't match the documented memory map. I would prefer to see a "Specify all PIL regions as defined in V10" or similar. Regards, Bjorn > Signed-off-by: Rohit kumar > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 23a253b..c0a012f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -88,6 +88,11 @@ > reg = <0 0x86200000 0 0x2d00000>; > no-map; > }; > + > + pil_adsp_mem: memory@8b100000 { > + reg = <0 0x8b100000 0 0x1a00000>; > + no-map; > + }; > }; > > cpus { > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., > is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. >